Add type addrShift to enable bigger encoder/decoder cache #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
==========================================
- Coverage 84.10% 84.09% -0.02%
==========================================
Files 49 49
Lines 23570 23590 +20
==========================================
+ Hits 19823 19837 +14
- Misses 2923 2925 +2
- Partials 824 828 +4 |
goccy
reviewed
May 9, 2021
jxskiss
commented
May 9, 2021
Change-Id: I630fa501f3b96702b69a40bc0b2f79f4db2a57eb
jxskiss
force-pushed
the
compact_type_cache
branch
from
8c813a4
to
7e03a13
Compare
|
The issues has been solved and re-pushed, by checking each address when iterating the typelinks, we don't need the addrs array anymore. |
|
LGTM ! Thank you for the contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime type data is aligned, by using a simple shift operation, we can make the encoder/decoder cache more compact (reduce to 1/32), thus comsume less memory and enble slice cache for large applications.