Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep original reference of slice element #229

Merged
merged 1 commit into from May 20, 2021

Conversation

goccy
Copy link
Owner

@goccy goccy commented May 19, 2021

fix #228

If the entered slice length is greater than zero, copy all references to the shared slice .

@goccy goccy force-pushed the feature/keep-original-slice-reference branch from c3b33c5 to d78854c Compare May 19, 2021 16:24
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2021

Codecov Report

Merging #229 (90d4d18) into master (d3951e3) will decrease coverage by 0.01%.
The diff coverage is 82.60%.

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
- Coverage   83.40%   83.38%   -0.02%     
==========================================
  Files          53       53              
  Lines       22947    22959      +12     
==========================================
+ Hits        19139    19145       +6     
- Misses       2978     2981       +3     
- Partials      830      833       +3     

- If the entered slice length is greater than zero, copy all references to the shared slice.
@goccy goccy force-pushed the feature/keep-original-slice-reference branch from d78854c to 90d4d18 Compare May 19, 2021 17:05
@goccy goccy merged commit 902fd6a into master May 20, 2021
@goccy goccy deleted the feature/keep-original-slice-reference branch May 20, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to unmarshal while "encoding/json" is working fine
2 participants