Add "func" Decoder #257
Merged
Add "func" Decoder #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 23, 2021 14:22
goccy
requested changes
Jun 23, 2021
| } | ||
| src := s.buf[start:s.cursor] | ||
| if len(src) > 0 { | ||
| switch src[0] { |
There was a problem hiding this comment.
It seems better to be able to make an error even if the values are different (e.g. true or false or other characters).
There was a problem hiding this comment.
I've added the cases for true and false.
The stdjson returns an error invalid character 'a' looking for beginning of value. This could be added to internal/errors/errors.go for other unexpected characters.
Codecov Report
@@ Coverage Diff @@
## master #257 +/- ##
==========================================
- Coverage 81.37% 80.97% -0.40%
==========================================
Files 46 47 +1
Lines 14663 14763 +100
==========================================
+ Hits 11932 11955 +23
- Misses 2177 2255 +78
+ Partials 554 553 -1 |
goccy
approved these changes
Jun 24, 2021
|
LGTM ! Thank you for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #255
The basic Decoder for values of type "func" accepts "null" as a valid value.
Omitting the field is also valid.
Both will result in the field having the value
nil.Any other value will result in an UnmarshalTypeError