New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTel: use semconv functions for filling out attributes #49
Comments
@morigs fasthttp is not compatible with http |
This is very unfortunate 😞 |
I think we can create same semconv methods that compatible with fasthttp.Request. But i'm not sure about that, i didn't review semconv's code much |
@morigs yes i have checked it. If you found out any missing attributes please feel free to create issues or PRs |
@WLun001 awesome, thank you! |
Currently, otel middleware add all the attributes manually.
I think it's better to use semconv functions for cases when
fasthttp.Request
is compatible withhttp.Request
because this will automatically add all recommended attributes. This is easier to maintain because following spec requires semconv package update only.Besides, I think it should use
SpanStatusFromHTTPStatusCodeAndSpanKind
instead ofSpanStatusFromHTTPStatusCode
The text was updated successfully, but these errors were encountered: