New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 SaveFile to default External Storage #1557
Conversation
Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
@Aliqyan e.g. SaveFileToStorage |
@Aliqyan can you change this ? |
thanks for the change, now we just need unittest for the new function also don't know if it wouldn't be better to just introduce a third parameter or a parameter object instead of the property on the app, because the external storage is currently only used there |
I don't have a preference. Using a parameter would allow consumers to save files to multiple different storage interfaces, but that could also be done by making the |
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
|
* fiber change * reference correct storage in SaveFile * seperate logic to new function * Change storage defination style, fix tests on go1.14 * Add unit test. Co-authored-by: Alex Bakker <abakks@hotmail.com> Co-authored-by: M. Efe Çetin <efectn@protonmail.com>
Allow client users to create a Storage interface for a default cloud based storage (like s3), and automatically save the file to the configured external file storage system if one exists.
S3 storage Addition (in GoFiber/Storage): gofiber/storage#227
Feature was suggested here: https://discordapp.com/channels/704680098577514527/848707314180423750/869831718876643388