Recover middleware: Added, fiber.Ctx as a first paremeter to StackTra… #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
|
thx, please also add a PR for our docs repository |
|
Wouldn't this be a breaking change? Maybe we could create a new method like |
|
Yes, should be a breaking change, would mention that in the release notes and refrain from using another method as it will only affect a few |
|
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide enough information so that others can review your pull request:
Added, fiber.Ctx as a first paremeter of the recover middleware StackTraceHandler.
Explain the details for making this change. What existing problem does the pull request solve?
Adding a fiber.Ctx as a parameter of StackTraceHandler function allow us to set stack trace string to c.Locals(). So, we will be able to log the stack trace on the ErrorHandler instead of putting that log twice for the stack trace.