Add direct download option when serving static files #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
Lian1230
force-pushed
the
enable-download-for-Static
branch
from
9249c01
to
9570adc
Compare
There was a problem hiding this comment.
@Lian1230
Please provide some unittests cases for this feature.
|
And don't forget the document repository https://github.com/gofiber/docs |
hi019
approved these changes
Feb 3, 2022
ReneWerner87
approved these changes
Feb 3, 2022
|
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
NorbertHauriel
pushed a commit
to NorbertHauriel/fiber
that referenced
this pull request
Feb 3, 2022
* enable download for app.Static wording * Add unit test. Co-authored-by: Muhammed Efe Çetin <efectn@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the details for making this change. What existing problem does the pull request solve?
For HTML element's download attribute, serverside header response must include "Content-Disposition: attachment" for cross origin request.