Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feature: add Next to Pprof and Expvar middlewares. #1737

Merged
merged 2 commits into from Jan 29, 2022
Merged

✨ feature: add Next to Pprof and Expvar middlewares. #1737

merged 2 commits into from Jan 29, 2022

Conversation

efectn
Copy link
Member

@efectn efectn commented Jan 29, 2022

No description provided.

@efectn efectn changed the title ✨ Feature: Add Next to Pprof and Expvar middlewares. ✨ feature: Add Next to Pprof and Expvar middlewares. Jan 29, 2022
@efectn efectn changed the title ✨ feature: Add Next to Pprof and Expvar middlewares. ✨ feature: add Next to Pprof and Expvar middlewares. Jan 29, 2022
ReneWerner87
ReneWerner87 reviewed Jan 29, 2022
View reviewed changes
Copy link
Member

@ReneWerner87 ReneWerner87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the readme files inside of the middleware folder and the document repository.

Thought by the way it is not necessary since we have the new skip middleware.
But if you have made the effort, I can take over the sense of unification.

@ReneWerner87 ReneWerner87 merged commit 5766fee into gofiber:master Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReneWerner87 ReneWerner87 ReneWerner87 approved these changes

Assignees
No one assigned
Labels
✏️ Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@efectn @ReneWerner87