Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Mention BodyParser error again ⚡️ #1738

Closed
OneSeven opened this issue Jan 30, 2022 · 10 comments
Closed

🚀 Mention BodyParser error again ⚡️ #1738

OneSeven opened this issue Jan 30, 2022 · 10 comments

Comments

@OneSeven
Copy link

OneSeven commented Jan 30, 2022

Is your feature request related to a problem?
Yes
Describe the solution you'd like
Would like to be able to implement the UnmarshalTypeError struct from the standard library
Describe alternatives you've considered
no
Additional context
I need to know where the parsed fit error is in that field, and the value of the information
I'm turning from echo, I might give up on fiber because of this problem, I don't think fiber should give up on excellent and convenient solutions!

@welcome
Copy link

welcome bot commented Jan 30, 2022

Thanks for opening your first issue here! 🎉 Be sure to follow the issue template! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@ReneWerner87
Copy link
Member

thanks for the report @OneSeven

above i can see that you have probably mentioned this before, can you link the pre-report here as well.

if not already present in the pre-report, can you create an example with the specific case ?

in my test i can see the field that led to the problem
image

would appreciate more information about the feature/problem solution

in issue #1375 #1387 we have already released the error messages for external comparison, maybe this will help you.
https://github.com/gofiber/fiber/blob/master/error.go#L5-L14

@OneSeven
Copy link
Author

@ReneWerner87

For details, see this issue #1010

@ReneWerner87
Copy link
Member

am curious how the pull request looks like, feel free to prepare something

pull requests are always welcome

@OneSeven
Copy link
Author

am curious how the pull request looks like, feel free to prepare something

pull requests are always welcome

I'm very sorry, my level is not enough, I hope the official can achieve

@ReneWerner87
Copy link
Member

ok, let's see if a contributor will take care of that, otherwise we will tackle that, but there is quite a lot on the table at the moment and few people are available

@OneSeven
Copy link
Author

OneSeven commented Feb 1, 2022

ok, let's see if a contributor will take care of that, otherwise we will tackle that, but there is quite a lot on the table at the moment and few people are available

The implementation is suitable, can it be like echo and put its error inside
https://github.com/labstack/echo/blob/master/echo.go#L107

For formData, XML's error hope is the same, not limited to json

@ReneWerner87
Copy link
Member

ReneWerner87 commented Feb 6, 2022

Please check it after the next release again( #1755)

@tomaswarynyca
Copy link
Contributor

@OneSeven v2.27.0 solved this problem?

@OneSeven
Copy link
Author

@OneSeven v2.27.0 solved this problem?

@efectn thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants