Doc(limiter): clarify variable name 'expire' #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NorbertHauriel
commented
Feb 2, 2022
•
NorbertHauriel
commented
- The variable 'expire' doesn't imply why it is different from 'expiration', so I made its name more specific.
- Comments mentioning it were changed accordingly.
|
Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
ReneWerner87
reviewed
Feb 2, 2022
This clarifies the intent of variable 'expire' by renaming to the more understandable 'resetInSec'. All mentions are renamed as well.
NorbertHauriel
force-pushed
the
master
branch
from
dfca66b
to
122cbfe
Compare
NorbertHauriel
changed the title
ReneWerner87
approved these changes
Feb 3, 2022
|
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.