🐛Backwards Incompatible Change to fiber.Error

[swengineer404]

Fiber version
2.26.0

Issue description
The change referenced here CLICK HERE in #1728 which was applied to a MINOR update is backwards incompatible. This change will break underlying structures that reference fiber.Error.Message using the concrete type "string".

One cannot simply imply that although the string can now be accessed via fiber.Message.Error() that this is a backwards-compatible change. The fact that code modification is needed by consumers in order to recorrect this issue is the exact representation of incompatibility.

This is not an argument of the effort required to fix or resolve this issue. It is merely a statement that semantic versioning is not being followed by this project if decisions/actions like this are being supported by the maintaining contributors.

Symantic versioning implies that both MINOR & PATCH updates must be done in a backwards compatible manner. This change is not backwards compatible in a typical scenario.

Changing the concrete type of publicly exposed API struct fields is bad practice for anything other than MAJOR backwards incompatible updates.

Code snippet

package main

import "github.com/gofiber/fiber/v2"

func ErrorHandler(c *fiber.Ctx, err error) error {
	var status int
	var message string

	switch e := err.(type) {
	case *fiber.Error:
		status = e.Code
		message = e.Message // This now throws an error because the concrete type of `Message` is no longer `string`
	default:
		status = http.StatusInternalServerError
		message = err.Error()
	}

	return c.Status(status).JSON(fiber.Map{"message": message})
}

[welcome]

Thanks for opening your first issue here! 🎉 Be sure to follow the issue template! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

[balcieren]

Fiber version 2.26.0

Issue description The change referenced here CLICK HERE in #1728 which was applied to a MINOR update is backwards incompatible. This change will break underlying structures that reference fiber.Error.Message using the concrete type "string".

One cannot simply imply that although the string can now be accessed via fiber.Message.Error() that this is a backwards-compatible change. The fact that code modification is needed by consumers in order to recorrect this issue is the exact representation of incompatibility.

This is not an argument of the effort required to fix or resolve this issue. It is merely a statement that semantic versioning is not being followed by this project if decisions/actions like this are being supported by the maintaining contributors.

Symantic versioning implies that both MINOR & PATCH updates must be done in a backwards compatible manner. This change is not backwards compatible in a typical scenario.

Changing the concrete type of publicly exposed API struct fields is bad practice for anything other than MAJOR backwards incompatible updates.

Code snippet

package main

import "github.com/gofiber/fiber/v2"

func ErrorHandler(c *fiber.Ctx, err error) error {
	var status int
	var message string

	switch e := err.(type) {
	case *fiber.Error:
		status = e.Code
		message = e.Message // This now throws an error because the concrete type of `Message` is no longer `string`
	default:
		status = http.StatusInternalServerError
		message = err.Error()
	}

	return c.Status(status).JSON(fiber.Map{"message": message})
}

thanks for issue, I have thought. Message is going to be string and I will add new property for Error struct. It is going to be interface so you can use if you want string or interface.

[balcieren]

@golangaddict #1768