馃┕ fix: backwards incompatible change to fiber.Error #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This broken change should wait for V3, AnyMessage is not elegant |
|
I agree with the previous reply, I think we should remove the AnyMessage changes and then merge this PR. Users can always return their own custom error in a handler and then convert it to JSON in the ErrorHandler. After this is merged, we can do a quick release to restore compatibility. |
|
Am of the same opinion, let's correct the error and work backward compatible |
Message should be interface for v3. May I fix over this pr ? |
|
Ready? 馃殌 |
hi019
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1767
backward compatible