Restore Original URL of the context after changing it #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
efectn
requested changes
Feb 20, 2022
@efectn Thanks for the suggestion. CopyString is better approach. Changing ImmutableString to CopyString |
ReneWerner87
approved these changes
Feb 20, 2022
|
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide enough information so that others can review your pull request:
This PR fixes two issues.
Restore original URL after proxy.Do issue
The proxy.Do method changes the c.OriginalURL() while setting the requestURI
req.SetRequestURI(addr)Since
proxy.Docan be used inside the fiber handlers, it will change the origialURL() since the reference to the context is passed. To fix this behaviour, I am resetting it once the proxy is done.The similar issue was raised for
sendFileand a fix was merged. However. I find that the fix is not working.Explain the details for making this change. What existing problem does the pull request solve?
Because of the current behaviour, if we use
c.OriginalURL()after invoking the proxy.Do() or sendFile() it will cause side effects asc.OriginalURL()will continue to point to the url changed in the proxy.Do() or sendFile() method.Note: using ImmutableString for persisting strings has a slight performance cost. Mentioned in the welcome page of fiber under Zero allocation
(This is my first PR in this project. Please let me know if I need to make some changes)