🚀 Human readable BodyLimit

[vanodevium]

Is your feature request related to a problem?
No

Describe the solution you'd like

What about make ability to set body size limit as human readable string?
Say we have environment variable BODY_SIZE=42MB
Then we read and set it to the fiber configuration.

Lets imagine BodyLimitString property in the fiber.Config

app := fiber.New(fiber.Config{
	BodyLimitString: os.Getenv("BODY_SIZE"),
})

And this property automatic parsed into bytes size

[ReneWerner87]

would treat the outside

integer numbers are perfect for config, everything else must be converted from outside

i.e. best you build a function that parses this or we could provide something in the utils, but in the config i wouldn't anchor it additionally

[vanodevium]

@ReneWerner87 Fine. Maybe we can provide some function into Config, like ParseBodyLimit() as utility?

Sorry for my persistence. I'm just starting my journey into golang development.
I want to get it right :)

[vanodevium]

Or you mean utils package?

[ReneWerner87]

converting does not really have anything to do with the bodylimit

we could provide a function in the utils called "ConvertToBits".

func ConvertToByte(humanReadbleBytes string) int

maybe here https://github.com/gofiber/fiber/blob/master/utils/common.go

[vanodevium]

Sounds good!
Can I try to make this function?

[ReneWerner87]

utils.ConvertToByte("42MB") // 4194304
utils.ConvertToByte("42MegaByte") // 4194304
utils.ConvertToByte("42MByte") // 4194304

[ReneWerner87]

Sounds good! Can I try to make this function?

sure, but don´t forget
unittests, documentation, benchmark method

[vanodevium]

@ReneWerner87 #1875
Please review and give me any feedback. I really try to do my best

[ReneWerner87]

Looks good, will merge it soon

[vanodevium]

Tnx!

Maybe I will be a good golang developer :)

[gaby]

@vanodevium How do you use this function? There's no documentation about it. I tried:

ConvertToBytes("20MB")
utils.ConvertToBytes("20MB")
fiber.ConvertToBytes("20MB")
common.ConvertToBytes("20MB")

They all return function is "undefined"

[ReneWerner87]

It's not released yet

But it's coming in the next days.

[gaby]

Thank you! 👍🏻