Spliting dump request to add Query 馃悰 馃毄 #1909
Conversation
Spliting []dump into dumps, and editing the dump[1] to = req.URL.String(), so we can tests itens that depends on querys from the request.
|
hi thanks for the work is this not already possible, just trying to understand what your customization is supposed to do can you explain this in more detail and if necessary send an example, which shows what was not possible before and is now possible |
|
think i now understand the point of this pull requests nevertheless please describe briefly in the pull request with an example, what is possible now, what did not work before so that we have this stored here for later can you please also extend the test with such a case |
| @@ -974,6 +975,11 @@ func (app *App) Test(req *http.Request, msTimeout ...int) (resp *http.Response, | |||
| return nil, err | |||
| } | |||
|
|
|||
| // adding back the query from URL, since dump cleans it | |||
| dumps := bytes.Split(dump, []byte(" ")) | |||
There was a problem hiding this comment.
please improve this construct with regard to performance and allocations
There was a problem hiding this comment.
I will take a better a look on this. The problem is: imagine you have a query /foo?bar=boo, when the dump is create the query part is removed, staying /foo.
Spliting []dump into dumps, and editing the dump[1] to = req.URL.String(), so we can tests itens that depends on querys from the request.
Spliting []dump into dumps, and editing the dump[1] to = req.URL.String(), so we can tests itens that depends on querys from the request.