🎨 Add black colors to default overriding function #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app.go
…ding in startupMessage
ReneWerner87
approved these changes
Aug 2, 2022
trim21
pushed a commit
to trim21/fiber
that referenced
this pull request
Aug 15, 2022
* Fix padding around app name in startup message when it contains non-ascii characters * fix conflict, allow ending space only for odd length strings * move startup message tests to listen_test.go * add black color to defaultColors overriding function, fix (again) padding in startupMessage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the black color was not overridden in the
defaultColorsfunction, if no black color was specified in the Config the black color was left undefined.For instance, it gave this result because the cyan color was not replace by the black one.
I also had to fix padding issues due to the length of the string that increased because of the color chars.