Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix infinitely app.Test #1997

Merged
merged 7 commits into from Aug 8, 2022
Merged

fix infinitely app.Test #1997

merged 7 commits into from Aug 8, 2022

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Aug 6, 2022

Explain the details for making this change. What existing problem does the pull request solve?

details are explained in #1996

add a defer in app.Test so runtime.Goexit can be handled.

@trim21
Copy link
Contributor Author

trim21 commented Aug 6, 2022

There is a data race error caused by Client failed ci, newly add test passed.

@ReneWerner87 ReneWerner87 merged commit e5eb8d3 into gofiber:master Aug 8, 2022
@trim21 trim21 deleted the patch-1 branch August 8, 2022 08:11
trim21 added a commit to trim21/fiber that referenced this pull request Aug 15, 2022
* diff

* better code

* err message

* code style

* up

* fix type error

* use time.Timer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🤗 [Question]: app.Test may hang infinitely with handler calling runtime.Goexit
2 participants