🐛 bug: fix proxy overwrote the wrong scheme

[wangjq4214]

Please provide enough information so that others can review your pull request:

Fix proxy overwrote the wrong scheme

Explain the details for making this change. What existing problem does the pull request solve?

close #2001

Commit formatting

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

[ReneWerner87]

thanks for the work, can you look over my comments

[wangjq4214]

thanks for the work, can you look over my comments

In this scenario, addr is a slice reference to the []byte c.fasthttp.Request.Header.requestURI, so when SetRequestURI is executed the requestURI changes causing addr to change as well.

More specifically, for the above example, addr is equivalent to requestURI[1:], so after the requestURI changes from /http://ip-api.com/json to http://ip-api.com/json addr will change from http://ip-api.com/json to ttp://ip-api.com/json, causing SetSchema to fail.

So I think it is necessary to make the above changes.

[ReneWerner87]

thanks for the work, can you look over my comments

In this scenario, addr is a slice reference to the []byte c.fasthttp.Request.Header.requestURI, so when SetRequestURI is executed the requestURI changes causing addr to change as well.

More specifically, for the above example, addr is equivalent to requestURI[1:], so after the requestURI changes from /http://ip-api.com/json to http://ip-api.com/json addr will change from http://ip-api.com/json to ttp://ip-api.com/json, causing SetSchema to fail.

yes i know so it should be enough to inject the copy when setting the requestUri

[ReneWerner87]

since this removes the link to the variable with the addr, the following change is then no longer necessary

[wangjq4214]

since this removes the link to the variable with the addr, the following change is then no longer necessary

When I use the modifications you mentioned above, I can't pass the test.

In SetRequestURI, h.requestURI = append(h.requestURI[:0], requestURI...) will be executed. Because the resulting []byte is shorter than the original one, it will execute in the original []byte. And no memory will be allocated.

[welcome]

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord