🐛 [Bug]: Monitor middleware ignores custom settings if default title is used.

[gaby]

Bug Description

When using the monitor middleware I noticed that if I don't change the title or refresh rate the other custom settings don't get applied.

The bug is on this line: https://github.com/gofiber/fiber/blob/master/middleware/monitor/config.go#L99

Where if title or refresh rate are the Default Values everything else gets ignored in the else.

How to Reproduce

Run code

Expected Behavior

Custom settings should be applied regardless of title/refresh rate.

Fiber Version

v2.36.0

Code Snippet (optional) (Bug, Font/Chart URLs are ignored)

package main

import (
	"log"

	"github.com/gofiber/fiber/v2"
	"github.com/gofiber/fiber/v2/middleware/monitor"
)

func main() {
	app := fiber.New()

	app.Get("/metrics", monitor.New(monitor.Config{
	    FontURL: "blah/blah.css",
	    ChartJsURL: "blah/blah.js",
    }))

	log.Fatal(app.Listen(":3000"))
}

Code Snippet (Working, Font/Chart URLs get applied)

package main

import (
	"log"

	"github.com/gofiber/fiber/v2"
	"github.com/gofiber/fiber/v2/middleware/monitor"
)

func main() {
	app := fiber.New()

	app.Get("/metrics", monitor.New(monitor.Config{
	    Title: "MyService Metrics Page",
	    FontURL: "blah/blah.css",
	    ChartJsURL: "blah/blah.js",
    }))

	log.Fatal(app.Listen(":3000"))
}

This bug doesn't show up in monitor_test.go, because the test is changing the Title to "New + DefaultTitle".

Checklist:

• I agree to follow Fiber's Code of Conduct.
• I have checked for existing issues that describe my problem prior to opening this one.
• I understand that improperly formatted bug reports may be closed without explanation.

[ReneWerner87]

@jfcg can you support here
initial code is comming from #1898

[jfcg]

I was just coding a cleaner solution to this :D

[gaby]

I was just coding a cleaner solution to this :D

One thing I wish it supported is passing files paths instead of urls.

Right now I have copies of the js/css files in my container and I expose them via app.Static('/static', './static').

Ideally the monitor config supported file based resources and used those in the html imports.

[jfcg]

I think we need to unexport default config as discussed in #1898

#1956 introduced the bug with the three new fields.