Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 bug: fix route constraints problems #2033

Merged
merged 3 commits into from Aug 26, 2022
Merged

🐛 bug: fix route constraints problems #2033

merged 3 commits into from Aug 26, 2022

Conversation

efectn
Copy link
Member

@efectn efectn commented Aug 19, 2022 •
edited

Bugs & Improvements:

  • strings.Split doesn't take care of escape char. It's potaintial bug for regex, datetime constraints.
  • Constraints weren't parsed properly when CaseSensitive is false.
  • I converted exactLen to len. It's shorter and better.

I couldn't see another problem. If you see another problems, you can share them to fix before releasing stable v2.37.0 version.

@ReneWerner87
Copy link
Member

ReneWerner87 commented Aug 24, 2022 •
edited by efectn

  • there is one more task which efectn want to fix

@ReneWerner87 ReneWerner87 merged commit aef7ea5 into master Aug 26, 2022
@efectn efectn deleted the fix-constraints branch August 26, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReneWerner87 ReneWerner87 ReneWerner87 approved these changes

Assignees
No one assigned
Labels
☢️ Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@efectn @ReneWerner87