Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 [Feature]: middleware/csrf custom extractor #2052

Merged

Conversation

sixcolors
Copy link
Member

@sixcolors sixcolors commented Aug 26, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Explain the details for making this change. What existing problem does the pull request solve?

This PR Fixes #2051

  • It makes cfg.Extractor an exported field
  • It renames built-in extractor creation functions so they are exported
  • It updates godocs comments and README.md with the new behavior
  • A test was written with a custom extractor
  • It remains downwardly compatible

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - https://github.com/gofiber/docs for https://docs.gofiber.io/
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@sixcolors sixcolors marked this pull request as ready for review August 26, 2022 16:56
@ReneWerner87 ReneWerner87 merged commit 6272d75 into gofiber:master Aug 28, 2022
@sixcolors sixcolors deleted the 2501-middleware-csrf-custom-extractor branch March 27, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

馃殌 [Feature]: Custom extractor option for middleware/csrf
2 participants