Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 bug: fix regex constraints #2059

Merged
merged 1 commit into from Aug 30, 2022
Merged

🐛 bug: fix regex constraints #2059

merged 1 commit into from Aug 30, 2022

Conversation

efectn
Copy link
Member

@efectn efectn commented Aug 29, 2022

Description

It was causing regex matching problem to remove \ chars from regex constraint data for regex matchers like \\d{4}-\\d{2}-\\d{2}. To fix this, we don't remove escape chars for regex parameters. Also we no longer need to add escape chars before routing-specific characters for regex constraints.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - https://github.com/gofiber/docs for https://docs.gofiber.io/
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@ReneWerner87 ReneWerner87 merged commit e72ea32 into master Aug 30, 2022
@efectn efectn deleted the fix-regex-constraint branch August 30, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants