Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 bug: remove prefork support from custom listeners #2060

Merged
merged 2 commits into from Aug 30, 2022

Conversation

efectn
Copy link
Member

@efectn efectn commented Aug 29, 2022

Description

We can't reuse old listeners for prefork. So it means, we're not able to use prefork with Listener(). I removed this part because of it's broken.
Fasthttp also doesn't support it.

Fixes #1254

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@ReneWerner87 ReneWerner87 merged commit cbfcac2 into master Aug 30, 2022
@efectn efectn deleted the remove-prefork-for-custom-listeners branch August 30, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Prefork bails out with panic message "listen tcp bind: address already in use"
2 participants