Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Add GetRoutes #2112

Merged
merged 1 commit into from Sep 27, 2022
Merged

Conversation

li-jin-gou
Copy link
Contributor

@li-jin-gou li-jin-gou commented Sep 22, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Explain the details for making this change. What existing problem does the pull request solve?

Fixes #2111

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation - https://github.com/gofiber/docs for https://docs.gofiber.io/

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@li-jin-gou li-jin-gou changed the title feat: Add GetRoutes ✨ feat: Add GetRoutes Sep 22, 2022
@ReneWerner87
Copy link
Member

ReneWerner87 commented Sep 22, 2022

thx

please check the build comments
and don´t forget the docs repository task

@li-jin-gou li-jin-gou force-pushed the feat/add_get_routes branch 2 times, most recently from d867314 to cf97045 Compare September 22, 2022 06:29
@li-jin-gou
Copy link
Contributor Author

li-jin-gou commented Sep 22, 2022

thx

please check the build comments and don´t forget the docs repository task

thanks

@acidjazz
Copy link

acidjazz commented Sep 22, 2022

@ReneWerner87 @li-jin-gou I think it might be useful to use this functionality of bypassing middleware-created routes in the EnablePrintRoutes feature - its a bit confusing seeing all the middleware ones

@acidjazz
Copy link

Another solution @li-jin-gou @ReneWerner87 is to group the methods together - this is how laravel shows their routes:

image

This is much cleaner than a row for each route

@ReneWerner87
Copy link
Member

You can create a pull request with a better representation and we can decide together.
we can also create a draft with only screenshots of many examples so that the community can then decide

@efectn
Copy link
Member

efectn commented Sep 22, 2022

Another solution @li-jin-gou @ReneWerner87 is to group the methods together - this is how laravel shows their routes:

image

This is much cleaner than a row for each route

Exactly agree. But not sure about how to get terminal width properly without any extra dep (to get needed dots count).

Or we can think any other design 🤔

@li-jin-gou
Copy link
Contributor Author

@ReneWerner87 @li-jin-gou I think it might be useful to use this functionality of bypassing middleware-created routes in the EnablePrintRoutes feature - its a bit confusing seeing all the middleware ones

This is a very good idea 😘

Copy link
Member

@ReneWerner87 ReneWerner87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are waiting for the docs repository adjustment

@li-jin-gou
Copy link
Contributor Author

li-jin-gou commented Sep 23, 2022

@ReneWerner87 Sorry,The computer that I'm using now can't install gitbook because of permission problems, so I can't run the document, I'll try a different computer this weekend.

  • I'll try again

app.go Outdated Show resolved Hide resolved
app.go Outdated Show resolved Hide resolved
@wangjq4214
Copy link
Member

You can create a pull request with a better representation and we can decide together. we can also create a draft with only screenshots of many examples so that the community can then decide

I also need this feature and hope to have a draft soon.

@ReneWerner87 ReneWerner87 merged commit ff348b5 into gofiber:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🤗 [Question]: Is it possible to get a current list of all of the routes?
5 participants