Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: support to set client in proxy mw #2117

Merged
merged 1 commit into from Sep 28, 2022

Conversation

li-jin-gou
Copy link
Contributor

@li-jin-gou li-jin-gou commented Sep 24, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Explain the details for making this change. What existing problem does the pull request solve?

Fixes #2116

  • In some scenarios the user need set up some complex client config via custom client
  • The case of a global client only gives the user no way to set up special configurations for only one middleware

so this pr allow to use custom client and distinguish global client and custom client in proxy mw and compatible with previous logic.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • update of the docs repository

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@li-jin-gou li-jin-gou changed the title ✨ optimize: add WithClient ✨ feat: add WithClient Sep 25, 2022
@li-jin-gou li-jin-gou force-pushed the optimize/proxy_client branch 3 times, most recently from 327b686 to 1ea2a8b Compare September 25, 2022 08:18
@li-jin-gou li-jin-gou changed the title ✨ feat: add WithClient ✨ feat: distinguish global client and custom client Sep 25, 2022
@li-jin-gou li-jin-gou changed the title ✨ feat: distinguish global client and custom client ✨ feat: distinguish global client and custom client in proxy mw Sep 25, 2022
@li-jin-gou li-jin-gou changed the title ✨ feat: distinguish global client and custom client in proxy mw ✨ feat: support to set client in proxy mw Sep 26, 2022
@ReneWerner87
Copy link
Member

please don´t forget

  • the update of the docs repository

@li-jin-gou
Copy link
Contributor Author

li-jin-gou commented Sep 26, 2022

please don´t forget

  • the update of the docs repository

Thanks for reminding. 😭
already modified doc.

@ReneWerner87 ReneWerner87 merged commit 8e8ad95 into gofiber:master Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 [Feature]: Add ability to configure client for proxy.Do
3 participants