New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 improve mounting behavior #2120
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efectn
commented
Sep 26, 2022
efectn
changed the title
🐛 bug: fix mounting doesn't work if when to declare it before routes
🐛 bug: fix mounting doesn't work if when to declare it before routes & improve routing behavior
Sep 28, 2022
efectn
changed the title
🐛 bug: fix mounting doesn't work if when to declare it before routes & improve routing behavior
🐛 bug: fix mounting doesn't work if when to declare it before routes & improve mounting behavior
Sep 28, 2022
efectn
changed the title
🐛 bug: fix mounting doesn't work if when to declare it before routes & improve mounting behavior
🐛 bug: improve mounting behavior
Sep 28, 2022
…ame, onRoute, onGroup, onGroupName hooks on mounted apps
ReneWerner87
requested changes
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some little adjustments needed
ReneWerner87
requested changes
Oct 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, but i have made a few comments which should clean up the code and make it easier to read and understand
ReneWerner87
approved these changes
Oct 25, 2022
ReneWerner87
changed the title
🐛 bug: improve mounting behavior
🚀 improve mounting behavior
Nov 18, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2066 and adds some features to mounting feature 🚀
Type of change
Please delete options that are not relevant.
Checklist:
Commit formatting:
Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/