Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: multi-byte AppName displays confusion #2148

Merged
merged 1 commit into from Oct 21, 2022

Conversation

li-jin-gou
Copy link
Contributor

@li-jin-gou li-jin-gou commented Oct 10, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Explain the details for making this change. What existing problem does the pull request solve?

Fixes #2147

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • add all three dependencies to the go mod and remove the copies

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@li-jin-gou li-jin-gou changed the title fix: solve wrong print width 🐛 fix: solve wrong print width Oct 10, 2022
@li-jin-gou
Copy link
Contributor Author

Effect1:
image

Effect2:
image

@li-jin-gou li-jin-gou changed the title 🐛 fix: solve wrong print width 🐛 fix: multi-byte AppName displays confusion Oct 10, 2022
@ReneWerner87
Copy link
Member

don't know if we should include this in the go.mod

i know fenny does not like dependencies to other packages, so he had made copies

we should treat the 3 packages from mattn the same in any case

so either make copies or put them all as dependencies in the go.mod

@gofiber/maintainers what do you think?

@efectn
Copy link
Member

efectn commented Oct 10, 2022

don't know if we should include this in the go.mod

i know fenny does not like dependencies to other packages, so he had made copies

we should treat the 3 packages from mattn the same in any case

so either make copies or put them all as dependencies in the go.mod

@gofiber/maintainers what do you think?

I support putting deps into the go.mod but gopsutil is really bloat dependency 🤔

@ReneWerner87
Copy link
Member

@efectn
Copy link
Member

efectn commented Oct 10, 2022

@ReneWerner87
Copy link
Member

@Fenny @hi019 are you okay with this ?

@ReneWerner87
Copy link
Member

ReneWerner87 commented Oct 17, 2022

@li-jin-gou can you

  • add all three dependencies to the go mod and remove the copies?

@li-jin-gou
Copy link
Contributor Author

@li-jin-gou can you

  • add all three dependencies to the go mod and remove the copies?

Sorry, I just saw it now and I will do so

@ReneWerner87
Copy link
Member

Thx

@li-jin-gou
Copy link
Contributor Author

I'm going to merge this PR. cc @ReneWerner87 @efectn

@ReneWerner87
Copy link
Member

give me a few minutes, i will merge it

@ReneWerner87 ReneWerner87 merged commit 5fb93fd into gofiber:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug]: multi-byte AppName displays confusion
3 participants