Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

middleware/proxy - 🐛 fix: solve data race in middleware/proxy's test #2153

Merged
merged 1 commit into from Oct 17, 2022

Conversation

li-jin-gou
Copy link
Contributor

@li-jin-gou li-jin-gou commented Oct 13, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Explain the details for making this change. What existing problem does the pull request solve?

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@li-jin-gou
Copy link
Contributor Author

li-jin-gou commented Oct 13, 2022

I found that the unit test I wrote before had datarace between use WithClient() and cli = client.

can I use mutex or atomic here or remove t.Parallel()?

@efectn
Copy link
Member

efectn commented Oct 13, 2022

I found that the unit test I wrote before had datarace between use WithClient() and cli = client.

can I use mutex or atomic here or remove t.Parallel()?

I think mutex

@li-jin-gou
Copy link
Contributor Author

I found that the unit test I wrote before had datarace between use WithClient() and cli = client.

can I use mutex or atomic here or remove t.Parallel()?

I think mutex

thanks

@li-jin-gou li-jin-gou changed the title fix: solve data race in middleware/proxy's test 🐛 fix: solve data race in middleware/proxy's test Oct 17, 2022
@ReneWerner87 ReneWerner87 merged commit d275091 into gofiber:master Oct 17, 2022
@ReneWerner87 ReneWerner87 changed the title 🐛 fix: solve data race in middleware/proxy's test middleware/proxy - 🐛 fix: solve data race in middleware/proxy's test Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants