Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 middleware/session - fix: Reset d.Data instead of deleting keys in it #2156

Merged
merged 1 commit into from Oct 17, 2022

Conversation

xbt573
Copy link
Contributor

@xbt573 xbt573 commented Oct 17, 2022

Description

This pull requests fixes possible memory leak in session middleware while golang/go#20135 is not resolved

Fixes #2149

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes
  • I tried to make my code as fast as possible with as few allocations as possible

@welcome
Copy link

welcome bot commented Oct 17, 2022

Thanks for opening this pull request! 馃帀 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@xbt573 xbt573 changed the title 馃悰 Reset d.Data instead of deleting keys in it 馃悰 Fix: Reset d.Data instead of deleting keys in it Oct 17, 2022
@ReneWerner87 ReneWerner87 merged commit a023fc2 into gofiber:master Oct 17, 2022
@welcome
Copy link

welcome bot commented Oct 17, 2022

Congrats on merging your first pull request! 馃帀 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@ReneWerner87 ReneWerner87 changed the title 馃悰 Fix: Reset d.Data instead of deleting keys in it 馃悰 middleware/session- Fix: Reset d.Data instead of deleting keys in it Oct 17, 2022
@ReneWerner87 ReneWerner87 changed the title 馃悰 middleware/session- Fix: Reset d.Data instead of deleting keys in it 馃悰 middleware/session - fix: Reset d.Data instead of deleting keys in it Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

馃悰 [Bug]: Potential memory leak in Data map in session middleware
3 participants