Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 [Feature]: Allow optional params with route constraints #2179

Merged
merged 1 commit into from Nov 1, 2022
Merged

馃殌 [Feature]: Allow optional params with route constraints #2179

merged 1 commit into from Nov 1, 2022

Conversation

jamestiotio
Copy link
Contributor

Description

This PR allows users to define routes with both optional parameters and constraints.

This PR fixes #2170.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

Signed-off-by: James R T <jamestiotio@gmail.com>
@welcome
Copy link

welcome bot commented Oct 29, 2022

Thanks for opening this pull request! 馃帀 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@ReneWerner87
Copy link
Member

can you please put an example in the documentation so that everyone knows that the feature exists and how to use it?
https://docs.gofiber.io/guide/routing#constraints

@ReneWerner87 ReneWerner87 merged commit c63a569 into gofiber:master Nov 1, 2022
@welcome
Copy link

welcome bot commented Nov 1, 2022

Congrats on merging your first pull request! 馃帀 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

馃 [Question]: route get parameter
4 participants