Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Leverage runtime/debug to print the full stack trace info #2183

Merged
merged 1 commit into from Oct 31, 2022

Conversation

panjf2000
Copy link
Contributor

Description

Use Stack() in runtime/debug, not in runtime, to get the panic stack trace info cuz the one in runtime/debug is a more convenient wrapper provided by Go team to print stack trace info, see golang/go#12363, besides, the current implementation only prints the first 1024 bytes, which might result in the missing vital information in the content after 1024 bytes, and the new approach resolves this issue by printing the full stack trace info.

Type of change

Please delete options that are not relevant.

  • Enhancement

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - https://github.com/gofiber/docs for https://docs.gofiber.io/
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@welcome
Copy link

welcome bot commented Oct 31, 2022

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@ReneWerner87 ReneWerner87 merged commit 24a6170 into gofiber:master Oct 31, 2022
@welcome
Copy link

welcome bot commented Oct 31, 2022

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@panjf2000 panjf2000 deleted the use-runtime-debug branch October 31, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants