Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track Configured Values #2221

Merged
merged 5 commits into from Nov 15, 2022

Conversation

calebcase
Copy link
Contributor

@calebcase calebcase commented Nov 14, 2022

Description

Between version v2.23.0 and v2.24.0 the behavior of Mount changed with regard to how the child's ErrorHandler is used. Before v2.24.0 if the child's error handler was not set, then it used the parent's error handler. From v2.24.0 to v2.39.0 (most recent as of this PR) the behavior is to use the child's error handler (which, even when it isn't explicitly set, is set to the DefaultErrorHandler by New()).

This change fixes that issue and provides a way for others to fix similar issues as they arise by checking if the value was explicitly configured.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - https://github.com/gofiber/docs for https://docs.gofiber.io/
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@welcome
Copy link

welcome bot commented Nov 14, 2022

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@calebcase calebcase changed the title WIP Use Parent Error Handler on Mount Track Configured Values Nov 14, 2022
@calebcase calebcase marked this pull request as ready for review November 14, 2022 19:28
app.go Outdated Show resolved Hide resolved
@ReneWerner87 ReneWerner87 merged commit 61b4496 into gofiber:master Nov 15, 2022
@welcome
Copy link

welcome bot commented Nov 15, 2022

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants