Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add New method and deprecate NewFlock #32

Merged
merged 1 commit into from Oct 5, 2018
Merged

Add New method and deprecate NewFlock #32

merged 1 commit into from Oct 5, 2018

Conversation

egonelbre
Copy link
Contributor

Fixes #25

theckman
theckman approved these changes Sep 26, 2018
View reviewed changes
Copy link
Member

@theckman theckman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution. I'll do the merge and release work for this tomorrow morning.

theckman
theckman requested changes Sep 26, 2018
View reviewed changes
Copy link
Member

@theckman theckman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged #23 which I think will fix the test that failed. Will you be willing to git pull --rebase upstream origin your branch and then force-push? That should give us the ✅.

@egonelbre
Copy link
Contributor Author

@theckman ping

@theckman theckman merged commit 4a2baac into gofrs:master Oct 5, 2018
theckman added a commit that referenced this pull request Oct 5, 2018
@theckman
Merge pull request #32 from egonelbre/master
7f43ea2 
Add New method and deprecate NewFlock

Signed-off-by: Tim Heckman <t@heckman.io>
@theckman
Copy link
Member

theckman commented Oct 5, 2018

v0.7.0 was released for this: https://github.com/gofrs/flock/releases/tag/v0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdecaf adamdecaf adamdecaf approved these changes

@theckman theckman theckman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@egonelbre @theckman @adamdecaf