Enable mobile navigation scrolling; add z-index #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namoscato
commented
Sep 11, 2020
layouts/partials/site-footer.html
Outdated
| @@ -41,7 +41,7 @@ | |||
|
|
|||
| <img src="/images/gopher-side_color.svg" alt="" class="absolute-l bottom-0 dn db-l h4 right-0 z-999"/> | |||
|
|
|||
| <div class="bg-primary-color-dark bottom-0 left-0 right-0 dn-l fixed pb3 ph3 w-100"> | |||
| <div class="bg-primary-color-dark bottom-0 left-0 right-0 dn-l fixed pa3 w-100 flex flex-column" style="max-height: 100%"> | |||
There was a problem hiding this comment.
Open to alternatives to the inline style, but tachyons doesn't include max-height utility classes (i.e. see tachyons-css/tachyons#619).
Fixes gohugoio#125 References 7019ac2
namoscato
changed the title
|
This was resolved a long time ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Docs nav on Hugo site isn't scrollable #141:
Fixes On Mobile in "Use Site Configuration Parameter" section, the tabs come over the navbar #125, referencing 7019ac2