Pull in the latest code from Go's template packages #11771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bep
force-pushed
the
fix/go-jsliterals-11757-11507
branch
from
b638f90
to
5ce8bc1
Compare
bep
force-pushed
the
fix/go-jsliterals-11757-11507
branch
from
5ce8bc1
to
f6e0663
Compare
|
@jmooring I have a nagging feeling that this i going to bite us, but I suspect this to be a big enough problem to not wait for Go 1.22? |
|
This PR has no effect on #11757, as expected. #11757 is invalid (user error). This PR fixes:
Of the two issues above, only 11507 was a regression, so I don't think this is a big problem. However, getting it out there early might uncover something new, which could potentially be fixed prior to Go 1.22 (Feb 2024). |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11757
Fixes #11507