Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace GetJSON calls in embedded shortcodes to prevent deprecation warnings #11971

Closed
5 tasks done
jmooring opened this issue Feb 1, 2024 · 1 comment · Fixed by #11972
Closed
5 tasks done

Replace GetJSON calls in embedded shortcodes to prevent deprecation warnings #11971

jmooring opened this issue Feb 1, 2024 · 1 comment · Fixed by #11972
Assignees
@jmooring
Labels
Enhancement Feature: Embedded Template Outdated

Comments

@jmooring
Copy link
Member

jmooring commented Feb 1, 2024 •
edited

  • tpl/tplimpl/embedded/templates/shortcodes/instagram_simple.html
  • tpl/tplimpl/embedded/templates/shortcodes/instagram.html
  • tpl/tplimpl/embedded/templates/shortcodes/twitter_simple.html
  • tpl/tplimpl/embedded/templates/shortcodes/twitter.html
  • tpl/tplimpl/embedded/templates/shortcodes/vimeo_simple.html
@jmooring jmooring self-assigned this Feb 1, 2024
@jmooring jmooring mentioned this issue Feb 1, 2024
Closed
jmooring added a commit to jmooring/hugo that referenced this issue Feb 2, 2024
@jmooring
tpl/tplimpl: Update embedded instagram, twitter, and vimeo shortcodes
5f9baba 
- Replace data.GetJSON calls with resources.GetRemote
- Remove usage of Facebook’s oEmbed Read feature

Fixes gohugoio#11971
@jmooring jmooring mentioned this issue Feb 2, 2024
Merged
@bep bep closed this as completed in #11972 Feb 2, 2024
bep pushed a commit that referenced this issue Feb 2, 2024
@jmooring @bep
tpl/tplimpl: Update embedded instagram, twitter, and vimeo shortcodes
d0788b9 
- Replace data.GetJSON calls with resources.GetRemote
- Remove usage of Facebook’s oEmbed Read feature

Fixes #11971
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jmooring jmooring

Labels
Enhancement Feature: Embedded Template Outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tpl/tplimpl: Update embedded instagram, twitter, and vimeo shortcodes jmooring/hugo
1 participant
@jmooring