Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use the same value in .Data.Term.Title as in .Title #12041

Closed
bep opened this issue Feb 15, 2024 · 2 comments · Fixed by #12051
Closed

Don't use the same value in .Data.Term.Title as in .Title #12041

bep opened this issue Feb 15, 2024 · 2 comments · Fixed by #12051
Assignees
Milestone

Comments

@bep
Copy link
Member

bep commented Feb 15, 2024

In 0.123.0 we changed the Title for kind term to be in line with others, but that means that it throws away some value having .Data.Term return the same.

I saw a discussion about using the i18n func for translation taxonomy terms, and I don't see anything wrong or hard doing something like this:

{{ $i18nKey := printf "%s.%s.title" .Data.Plural .Data.Term }}
{{ $title := i18n $i18nKey | default .Title }}
@bep bep added this to the v0.123.0 milestone Feb 15, 2024
@bep bep self-assigned this Feb 15, 2024
@McShelby
Copy link

Just for the record, the discussion was about translating the taxonomy name itself, e.g tags or categories.

Putting term titles in an i18n file is a nice feature but I am not sure if many users would use this as it is easier to achieve this by overwriting the according _index.md file.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants