-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS files not found when vendoring modules in v0.123.x #12137
Comments
I just tested this OK:
You are right that it fails when running the vendored version directly from the theme, but comparing the vendored directories from v0.122 and v0.123 shows that they are the same, which means that it's not the vendoring that's failing. Hmm. |
OK, I think I see what's happening now. |
That’s encouraging! As a side note, the single reason to vendor the modules is to provide a consistent path for the safe listed files for the purge-css utility. As far as I’m aware, these (external) utilities do not have access to the Hugo mounts. But perhaps there’s a more elegant approach? |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What version of Hugo are you using (
hugo version
)?Does this issue reproduce with the latest release?
Yes
Context
When upgrading Hugo from v0.122.0 to v0.123.3 I get a CSS transpiler error. Below the full error logs (specific to the Hinode theme):
The error only occurs when running
hugo mod vendor
.To reproduce
git clone https://github.com/gethinode/hinode.git cd hinode hugo mod vendor hugo server
Removing the
_vendor
directory solves theTOCSS
transpiler error (it doesn't seem to matter if usinglibsass
ordartsass
).Rationale
The Hinode theme vendors its modules to add specific CSS files to a safe list, preventing certain style definitions to be purged from the final CSS file. See
config/postcss.config.js
for more details. Purge is enabled by settingpurge = true
in the[style]
section ofconfig/_default/params.toml
.The text was updated successfully, but these errors were encountered: