Parent .Pages collection incorrect when adjacent sections are named similarly

[jmooring]

The issue title isn't great. The problem occurs with v0.123.0 and later.

I ran into this on the Hugo docs site when visiting https://gohugo.io/methods/. You should see 10 entries, one for each subsection. Instead, there are 14 entries. The 4 extra entries are regular pages under the "menu" directory. Adjacent to the "menu" directory is the "menu-entries" directory. The two directories both begin with "menu" --- that is what triggers the problem (i.e., rename the "menu" directory to "x" and the problem goes away).

Example

content/
├── s1/
│   ├── _index.md
│   └── p1.md
├── s1-foo/
│   ├── _index.md
│   └── p2.md
└── _index.md

On the home page, the .Page.Pages collection should contain s1 and s1-foo. Instead, it contains s1, s1-foo, and p1. The problem occurs on section pages as well as the home page.

git clone --single-branch -b hugo-github-issue-12169 https://github.com/jmooring/hugo-testing hugo-github-issue-12169
cd hugo-github-issue-12169
rm -rf public/ && hugo && cat public/index.html 

Expected (v0.122.0)

__|s1|s1-foo|__

Actual (v0.123.4)

__|p1|s1|s1-foo|__

The hyphen is part of the problem:
If you rename the s1-foo directory to s1foo everything works as expected.

Failing test case

This test certainly fails, but fails just a bit differently than shown above. The actual result is:

__|p1|p2|s1|s1-foo|__

Note the addition of p2 to the collection. Not sure why this fails differently.

failing test case

func TestFoo(t *testing.T) {
	t.Parallel()

	files := `
-- config.toml --
disableKinds = ['rss','sitemap','taxonomy','term']
-- layouts/_default/list.html --
__|{{ range .Pages }}{{ .Title }}|{{ end }}__
-- layouts/_default/single.html --
{{ .Title }}|
-- content/s1/_index.md --
---
title: s1
---
-- content/s1/p1.md --
---
title: p1
---
-- content/s1-foo/_index.md --
---
title: s1-foo
---
-- content/s1/p2.md --
---
title: p2
---
  `

	b := hugolib.Test(t, files)

	b.AssertFileContent("public/index.html", "__|s1|s1-foo|__")
}

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.