Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resources/page: Make Taxonomy.Get and Taxonomy.Count case-insensitive #12177

Closed
jmooring opened this issue Feb 29, 2024 · 1 comment · Fixed by #12180
Closed

resources/page: Make Taxonomy.Get and Taxonomy.Count case-insensitive #12177

jmooring opened this issue Feb 29, 2024 · 1 comment · Fixed by #12180

Comments

@jmooring
Copy link
Member

jmooring commented Feb 29, 2024

https://github.com/gohugoio/hugo/blob/master/resources/page/taxonomy.go#L59-L65

For example, change this:

// Get the weighted pages for the given key.
func (i Taxonomy) Get(key string) WeightedPages {
	return i[key]
}

To this:

// Get the weighted pages for the given key.
func (i Taxonomy) Get(key string) WeightedPages {
	return i[strings.ToLower(key)]
}

This would allow us to do this:

{{ $count := site.Taxonomies.tags.Count "Bob Smith" }}
{{ $weightedPages := site.Taxonomies.tags.Get "Bob Smith" }}

instead of this:

{{ $count := site.Taxonomies.tags.Count ("Bob Smith" | lower) }}
{{ $weightedPages := site.Taxonomies.tags.Get ("Bob Smith" | lower) }}
@jmooring jmooring changed the title resources/page: Make Taxonomy.Get case-insensitive resources/page: Make Taxonomy.Get and Taxonomy.Count case-insensitive Feb 29, 2024
@bep bep added this to the v0.123.7 milestone Feb 29, 2024
@bep bep closed this as completed in #12180 Mar 1, 2024
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants