Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image dithering filter to build low-tech websites #8598

Closed
rdelaage opened this issue May 31, 2021 · 8 comments · Fixed by #12016
Closed

Add image dithering filter to build low-tech websites #8598

rdelaage opened this issue May 31, 2021 · 8 comments · Fixed by #12016
Assignees
Milestone

Comments

@rdelaage
Copy link

It would be great to be able to select a filter to dither image and reduce final website size in image processing. The lowtech magazine use a filter to dither images. We could have the same in hugo by using this library and it could be selecting in image processing filters.

@bep bep added Enhancement and removed Proposal labels Jun 1, 2021
@bep bep added this to the v0.84 milestone Jun 1, 2021
@bep
Copy link
Member

bep commented Jun 1, 2021

We could add this if we could do it by not adding another dependency. I think the standard library has a simple dithering filter, which I think should be good enough for this.

@diantanjung
Copy link

I want to solve this issue

@diantanjung
Copy link

diantanjung commented Jun 9, 2021

hi @bep
Is there any documentation for debugging and testing for hugo project? I have changed in filter.go add add some file. But after I run mage install, the change does not work. Is I miss something?

Is any cache mechanism in hugo for last code in shortcode or layout?

@diantanjung
Copy link

Ok, Please explain the features of the dithering image. If any input and output images will be very helpful.

@bep
Copy link
Member

bep commented Jun 16, 2021

I don't have any stake in this other than that I'll most likely end up maintaining what's added. But I was originally thinking about using draw.FloydSteinberg ... but I haven't researched this.

https://golang.org/pkg/image/draw/

@diantanjung
Copy link

disintegration/gift#25

@bep bep modified the milestones: v0.84, v0.85 Jun 18, 2021
@diantanjung
Copy link

hi bep, Could I use draw.FloydSteinberg (but I modified it) to implement gift.Filter?
Or Is there another approach?

thanks

@bep bep modified the milestones: v0.85, v0.86 Jul 5, 2021
@bep bep modified the milestones: v0.86, v0.87, v0.88 Jul 26, 2021
@bep bep modified the milestones: v0.88, v0.89 Sep 2, 2021
@bep bep modified the milestones: v0.89, v0.90 Nov 2, 2021
@bep bep modified the milestones: v0.90, v0.91.0 Dec 13, 2021
@bep bep modified the milestones: v0.91.0, v0.92.0 Dec 22, 2021
@bep bep modified the milestones: v0.92.0, v0.93.0 Jan 12, 2022
@bep bep added this to the v0.116.0 milestone Jun 30, 2023
@bep bep modified the milestones: v0.116.0, v0.117.0 Aug 1, 2023
@bep bep modified the milestones: v0.117.0, v0.118.0 Aug 30, 2023
@bep bep modified the milestones: v0.118.0, v0.119.0 Sep 15, 2023
@bep bep modified the milestones: v0.119.0, v0.120.0 Oct 4, 2023
@bep bep modified the milestones: v0.120.0, v0.121.0 Oct 31, 2023
@bep bep modified the milestones: v0.121.0, v0.122.0 Dec 6, 2023
@bep bep modified the milestones: v0.122.0, v0.123.0, v0.124.0 Jan 27, 2024
jmooring added a commit to jmooring/hugo that referenced this issue Feb 8, 2024
jmooring added a commit to jmooring/hugo that referenced this issue Feb 10, 2024
jmooring added a commit to jmooring/hugo that referenced this issue Feb 10, 2024
jmooring added a commit to jmooring/hugo that referenced this issue Feb 11, 2024
jmooring added a commit to jmooring/hugo that referenced this issue Feb 11, 2024
jmooring added a commit to jmooring/hugo that referenced this issue Feb 11, 2024
@bep bep closed this as completed in 21d9057 Feb 11, 2024
Copy link

github-actions bot commented Mar 4, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants