Add support for Go's net/url JoinPath

[mattdeluco]

I ran into an issue trying to use path.Join to join a path to a Permalink (I'm new to Hugo and Go): path.Join uses filepath.Join under the hood, which calls filepath.Clean. Among other things, Clean will remove any consecutive slashes, clobbering https:// in .Permalink, making it for example https:/example.com/path/to/a/thing. Go's path.Join also does the same thing with its own implementation of Clean.

I dug around and found there's a very recently added (March 9th) JoinPath function in net/url. I think it may have missed Go 1.18 by 5 days: it would be a convenient addition to Hugo on the next release of Go.

[bep]

path.Join uses filepath.Join under the hood, which calls

I'm pretty sure the above isn't true, but you are right, we are going to use the new JoinPath, but assuming it's not backported to Go 1.18, I suspect we need to wait until Go 1.20.

[earthboundkid]

I think it may have missed Go 1.18 by 5 days

For the record, even though Go 1.18 shipped in March, the feature freeze for it was back in November. It's part of the Go release cycle: https://github.com/golang/go/wiki/Go-Release-Cycle#timeline

I actually did just barely miss the window for adding http.MaxBytesError to 1.18 because I wasn't paying attention to the freeze date.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.