Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

masterKey被多次写入pcapng文件中 #542

Closed
chenzhiguo14-qq opened this issue May 14, 2024 · 3 comments · Fixed by #546
Closed

masterKey被多次写入pcapng文件中 #542

chenzhiguo14-qq opened this issue May 14, 2024 · 3 comments · Fixed by #546
Labels
question Further information is requested

Comments

@chenzhiguo14-qq
Copy link

在pcap模式中, 我看到每次调用savePcapng方法, 都会把masterKeyBuffer写入到pcap文件中, 这样使pcap文件中有很多的DSB

请问这样是否合理?
是否可以写入以后, 把masterKeyBuffer清空呢?

还有一个问题: masterKey何时会过期?(我对tls的机制不是很了解) 能否在masterKey过期是时候, 把它从masterKeyBuffer中去掉?
@cfc4n cfc4n added the question Further information is requested label May 17, 2024
@cfc4n
Copy link
Member

cfc4n commented May 17, 2024

给一些例子?
创建了几个TLS链接？写入了几次DSB？ 多个DSB对pcap文件有什么影响呢？

@chenzhiguo14-qq
Copy link
Author

以下是我自己抓的一个文件(持续的时间很短)中的DSB的截图

image
image
image
image

附件是pcap文件
ecapture_all3.zip

可以看到这些DSB都是相同的, 在wireshark打开的时候, 这些DSB并没有什么影响, 但是这样会不断的增大文件的体积

@cfc4n
Copy link
Member

cfc4n commented May 18, 2024

看上去确实写了很多次。能否给出完整的重现步骤？

cfc4n added a commit that referenced this issue May 18, 2024
@cfc4n
user: fixed #542, masterkey being written to pcapng multiple times.
bfaaf99 
Signed-off-by: CFC4N <cfc4n.cs@gmail.com>
@cfc4n cfc4n linked a pull request May 18, 2024 that will close this issue
user: fixed #542, masterkey being written to pcapng multiple times. #546
Merged
cfc4n added a commit that referenced this issue May 19, 2024
@cfc4n
user: fixed #542, masterkey being written to pcapng multiple times. (#…
11a498a 
…546)

Signed-off-by: CFC4N <cfc4n.cs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

user: fixed #542, masterkey being written to pcapng multiple times. gojue/ecapture
2 participants
@cfc4n @chenzhiguo14-qq