Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for failing test for AWS keyspace #634

Merged
merged 5 commits into from Oct 15, 2021
Merged

Conversation

Baumanar
Copy link
Contributor

@Baumanar Baumanar commented Oct 11, 2021

This continues #579, the tests failed because of a parsing error

@coveralls
Copy link

coveralls commented Oct 11, 2021

Pull Request Test Coverage Report for Build 1341007242

  • 11 of 19 (57.89%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 57.69%

Changes Missing Coverage Covered Lines Changed/Added Lines %
database/cassandra/cassandra.go 11 19 57.89%
Files with Coverage Reduction New Missed Lines %
database/cassandra/cassandra.go 1 45.5%
Totals Coverage Status
Change from base Build 1340434566: -0.01%
Covered Lines: 3721
Relevant Lines: 6450

💛 - Coveralls

@Baumanar Baumanar changed the title Fix test for AWS keyspace Fix for failing test for AWS keyspace Oct 12, 2021
dhui
dhui previously approved these changes Oct 14, 2021
Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the tests from the other PR (#579)!
It looks like go.mod was updated since you opened the PR. Could you resolve the conflicts?

@dhui dhui mentioned this pull request Oct 14, 2021
@Baumanar
Copy link
Contributor Author

Hey, thanks for your quick reply. I rebased my branch and added a go mod tidy step !

@dhui dhui merged commit 1ba9bec into golang-migrate:master Oct 15, 2021
@yury-kozlov
Copy link

@dhui Is there any estimated date of the next release (of golang-migrate) ?
we are particularly interested in this fix (where truncate was replaced with delete)

@dhui
Copy link
Member

dhui commented Oct 17, 2021

This is available in v4.15.1.
In the future, you can always use the master branch after a PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants