allow API calls without GAE context #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zevdg
force-pushed
the
noticket
branch
5 times, most recently
from
d91a522
to
82c5a38
Compare
The ApiHost used to require a security ticket for all API calls, so the client side code used to be able to assume that any request without one was invalid and reject it. The backend now is able to handle requests without security tickets in many cases, so the client side check is now just getting in the way. This change removes that check and lets the backend attempt to handle all requests. The way the client implementation happened to require a security ticket was actually by requiring a GAE context. This change removes that constraint as well and removes the now-unecessary BackgroundContext.
|
This is exciting. I may need to take a look tomorrow though. I'm fixing a customer issue. |
jinglundong
approved these changes
Jul 15, 2022
zevdg
added a commit
to zevdg/appengine
that referenced
this pull request
Sep 8, 2022
This makes the test more hermetic by avoiding the need to set env vars, and it also avoids some unecessary duplication of test helper logic by leveraging some of aetest's underlying implementation. This change was originally part of golang#284, but I split it out because it's not compatible with v1's log flushing tests, and it would have added unecessary noise to that PR.
zevdg
added a commit
to zevdg/appengine
that referenced
this pull request
Sep 8, 2022
This makes the test more hermetic by avoiding the need to set env vars, and it also avoids some unecessary duplication of test helper logic by leveraging some of aetest's underlying implementation. This change was originally part of golang#284, but I split it out because it's not compatible with v1's log flushing tests, and it would have added unecessary noise to that PR.
zevdg
added a commit
to zevdg/appengine
that referenced
this pull request
Sep 8, 2022
This makes the test more hermetic by avoiding the need to set env vars, and it also avoids some unecessary duplication of test helper logic by leveraging some of aetest's underlying implementation. This change was originally part of golang#284, but I split it out because it's not compatible with v1's log flushing tests, and it would have added unecessary noise to that PR.
zevdg
added a commit
to zevdg/appengine
that referenced
this pull request
Sep 13, 2022
This makes the test more hermetic by avoiding the need to set env vars, and it also avoids some unecessary duplication of test helper logic by leveraging some of aetest's underlying implementation. This change was originally part of golang#284, but I split it out because it's not compatible with v1's log flushing tests, and it would have added unecessary noise to that PR.
ludoch
pushed a commit
that referenced
this pull request
Mar 16, 2023
This makes the test more hermetic by avoiding the need to set env vars, and it also avoids some unecessary duplication of test helper logic by leveraging some of aetest's underlying implementation. This change was originally part of #284, but I split it out because it's not compatible with v1's log flushing tests, and it would have added unecessary noise to that PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ApiHost used to require a security ticket for all API calls, so the
client side code used to be able to assume that any request without one
was invalid and reject it. The backend now is able to handle requests
without security tickets in many cases, so the client side check is now
just getting in the way. This change removes that check and lets the
backend attempt to handle all requests.
The way the client implementation happened to require a security ticket
was actually by requiring a GAE context. This change removes that
constraint as well and removes the now-unecessary BackgroundContext.
Also includes some minor cleanups/refactoring