Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: go1.19.11
Choose a base ref
...
head repository: golang/go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: go1.19.12
Choose a head ref
  • 5 commits
  • 10 files changed
  • 5 contributors

Commits on Jul 19, 2023

  1. [release-branch.go1.19] cmd/compile: on PPC64, fix sign/zero extensio…

    …n when masking
    
    This backport required manual cleanup as go1.20 combined the
    ANDCCconst and ANDconst opcodes into one. Similarly, CL 456736
    introduced a suble bug by using (Select1 (ANDCCconst ...)). This
    usually worked because the same rule quietly changes the type
    of the newly created ANDCCconst to a tuple. This change exposed
    the bug, so fix it too.
    
    (ANDconst [y] (MOV.*reg x)) should only be merged when zero
    extending. Otherwise, sign bits are lost on negative values.
    
    (ANDconst [0xFF] (MOVBreg x)) should be simplified to a zero
    extension of x. Likewise for the MOVHreg variant.
    
    Fixes #61319
    
    Change-Id: I04e4fd7dc6a826e870681f37506620d48393698b
    Reviewed-on: https://go-review.googlesource.com/c/go/+/508775
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Run-TryBot: Paul Murphy <murp@ibm.com>
    Reviewed-by: Bryan Mills <bcmills@google.com>
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/509018
    Auto-Submit: Heschi Kreinick <heschi@google.com>
    TryBot-Bypass: Heschi Kreinick <heschi@google.com>
    pmur authored and gopherbot committed Jul 19, 2023

    Verified

    This commit was signed with the committer’s verified signature.
    renovate-bot Mend Renovate
    Copy the full SHA
    6ce543d View commit details
  2. [release-branch.go1.19] net: tolerate permission errors in interface …

    …tests
    
    On our linux-arm64 builders, we're getting permission errors despite
    running as root. Detect those errors and skip the test.
    
    For #61414.
    Fixes #61448.
    
    Change-Id: I5d7c45789337bee3860b19335bbb9eb884c48986
    Reviewed-on: https://go-review.googlesource.com/c/go/+/510737
    Auto-Submit: Heschi Kreinick <heschi@google.com>
    Run-TryBot: Heschi Kreinick <heschi@google.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    (cherry picked from commit 8e1ec1c)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/511097
    Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
    TryBot-Bypass: Heschi Kreinick <heschi@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    heschi authored and gopherbot committed Jul 19, 2023
    Copy the full SHA
    8c8277b View commit details

Commits on Jul 26, 2023

  1. [release-branch.go1.19] cmd/asm, cmd/internal/obj: generate proper at…

    …omic ops for riscv64
    
    Go's memory model closely follows the approach C++ concurrency memory
    model (https://go.dev/ref/mem) and Go atomic "has the same semantics as C++'s
    sequentially consistent atomics".
    
    Meanwhile according to RISCV manual A.6 "Mappings from C/C++ primitives to RISC-V primitives".
    C/C++ atomic operations (memory_order_acq_rel) should be map to "amo<op>.{w|d}.aqrl"
    LR/SC (memory_order_acq_rel) should map to "lr.{w|d}.aq; <op>; sc.{w|d}.rl"
    
    goos: linux
    goarch: riscv64
    pkg: runtime/internal/atomic
                    │ atomic.old.bench │          atomic.new.bench           │
                    │      sec/op      │   sec/op     vs base                │
    AtomicLoad64-4         4.216n ± 1%   4.202n ± 0%        ~ (p=0.127 n=10)
    AtomicStore64-4        5.040n ± 0%   6.718n ± 0%  +33.30% (p=0.000 n=10)
    AtomicLoad-4           4.217n ± 0%   4.213n ± 0%        ~ (p=0.145 n=10)
    AtomicStore-4          5.040n ± 0%   6.718n ± 0%  +33.30% (p=0.000 n=10)
    And8-4                 9.237n ± 0%   9.240n ± 0%        ~ (p=0.582 n=10)
    And-4                  5.878n ± 0%   6.719n ± 0%  +14.31% (p=0.000 n=10)
    And8Parallel-4         28.44n ± 0%   28.46n ± 0%   +0.07% (p=0.000 n=10)
    AndParallel-4          28.40n ± 0%   28.43n ± 0%   +0.11% (p=0.000 n=10)
    Or8-4                  8.399n ± 0%   8.398n ± 0%        ~ (p=0.357 n=10)
    Or-4                   5.879n ± 0%   6.718n ± 0%  +14.27% (p=0.000 n=10)
    Or8Parallel-4          28.43n ± 0%   28.45n ± 0%   +0.09% (p=0.000 n=10)
    OrParallel-4           28.40n ± 0%   28.43n ± 0%   +0.11% (p=0.000 n=10)
    Xadd-4                 30.05n ± 0%   30.10n ± 0%   +0.18% (p=0.000 n=10)
    Xadd64-4               30.05n ± 0%   30.09n ± 0%   +0.12% (p=0.000 n=10)
    Cas-4                  60.48n ± 0%   61.13n ± 0%   +1.08% (p=0.000 n=10)
    Cas64-4                62.28n ± 0%   62.34n ± 0%        ~ (p=0.810 n=10)
    Xchg-4                 30.05n ± 0%   30.09n ± 0%   +0.15% (p=0.000 n=10)
    Xchg64-4               30.05n ± 0%   30.09n ± 0%   +0.13% (p=0.000 n=10)
    geomean                15.42n        16.17n        +4.89%
    
    Fixes #61470
    
    Change-Id: I97b5325db50467eeec36fb079bded7b09a32330f
    Reviewed-on: https://go-review.googlesource.com/c/go/+/508715
    Reviewed-by: Austin Clements <austin@google.com>
    Reviewed-by: Joel Sing <joel@sing.id.au>
    Run-TryBot: M Zhuo <mzh@golangcn.org>
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    Reviewed-by: Bryan Mills <bcmills@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    (cherry picked from commit 890b96f)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/511495
    Reviewed-by: M Zhuo <mzh@golangcn.org>
    Run-TryBot: Matthew Dempsky <mdempsky@google.com>
    TryBot-Bypass: Matthew Dempsky <mdempsky@google.com>
    Auto-Submit: Matthew Dempsky <mdempsky@google.com>
    Reviewed-by: Matthew Dempsky <mdempsky@google.com>
    mengzhuo authored and gopherbot committed Jul 26, 2023
    Copy the full SHA
    f9c174f View commit details

Commits on Aug 1, 2023

  1. [release-branch.go1.19] crypto/tls: restrict RSA keys in certificates…

    … to <= 8192 bits
    
    Extremely large RSA keys in certificate chains can cause a client/server
    to expend significant CPU time verifying signatures. Limit this by
    restricting the size of RSA keys transmitted during handshakes to <=
    8192 bits.
    
    Based on a survey of publicly trusted RSA keys, there are currently only
    three certificates in circulation with keys larger than this, and all
    three appear to be test certificates that are not actively deployed. It
    is possible there are larger keys in use in private PKIs, but we target
    the web PKI, so causing breakage here in the interests of increasing the
    default safety of users of crypto/tls seems reasonable.
    
    Thanks to Mateusz Poliwczak for reporting this issue.
    
    Updates #61460
    Fixes #61579
    Fixes CVE-2023-29409
    
    Change-Id: Ie35038515a649199a36a12fc2c5df3af855dca6c
    Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/1912161
    Reviewed-by: Damien Neil <dneil@google.com>
    Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
    Run-TryBot: Roland Shoemaker <bracewell@google.com>
    (cherry picked from commit d865c715d92887361e4bd5596e19e513f27781b7)
    Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/1965487
    Reviewed-on: https://go-review.googlesource.com/c/go/+/514915
    Run-TryBot: David Chase <drchase@google.com>
    Reviewed-by: Matthew Dempsky <mdempsky@google.com>
    TryBot-Bypass: David Chase <drchase@google.com>
    rolandshoemaker authored and dr2chase committed Aug 1, 2023
    Copy the full SHA
    2300f7e View commit details
  2. [release-branch.go1.19] go1.19.12

    Change-Id: Id84d0d837b59d52e0c93560f0c31dc7226cad912
    Reviewed-on: https://go-review.googlesource.com/c/go/+/514937
    Reviewed-by: Matthew Dempsky <mdempsky@google.com>
    Reviewed-by: Heschi Kreinick <heschi@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    Run-TryBot: Gopher Robot <gobot@golang.org>
    gopherbot committed Aug 1, 2023
    Copy the full SHA
    0ae54dd View commit details
Loading