Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: update js/wasm port for Node.js 18 #57614

Closed
dmitshur opened this issue Jan 4, 2023 · 8 comments
Closed

all: update js/wasm port for Node.js 18 #57614

dmitshur opened this issue Jan 4, 2023 · 8 comments
Labels
arch-wasm WebAssembly issues early-in-cycle A change that should be done early in the 3 month dev cycle. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-JS umbrella
Milestone
Go1.21

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jan 4, 2023 •
edited

The recently-added js/wasm builder with Node.js 18 reports that all.bash doesn't pass out of the box.
This is the umbrella issue to track everything needed to migrate the js/wasm port from Node.js 14 to 18.
(It can't happen now because we're in the freeze for 1.20, so placing in 1.21 milestone.)

CC @golang/js, @golang/wasm, @johanbrandhorst.
@dmitshur dmitshur added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. early-in-cycle A change that should be done early in the 3 month dev cycle. arch-wasm WebAssembly issues OS-JS umbrella labels Jan 4, 2023
@dmitshur dmitshur added this to the Go1.21 milestone Jan 4, 2023
@gopherbot
Copy link

Change https://go.dev/cl/460575 mentions this issue: dashboard: update js-wasm-node18 known issue and limit it to Go 1.21+

gopherbot pushed a commit to golang/build that referenced this issue Jan 4, 2023
@dmitshur @gopherbot
dashboard: update js-wasm-node18 known issue and limit it to Go 1.21+
90d9983 
The js/wasm port is compatible with Node.js 14 but not Node.js 18, and
we're in the middle of a freeze so it's too late to make changes now.
Target the new builder for Go 1.21 and newer, and replace the "add
builder" known issue with umbrella tracking issue for Node 18.

Keep the current js-wasm builer with Node 14 as is so that the port
doesn't deteriorate further in the meantime. It can be disabled for tip
as soon as we have CLs to make all.bash pass with Node 18 all prepared.

Fixes golang/go#57017.
Updates golang/go#57614.

Change-Id: I66cb4210f1e899329550162242c72de0da7aedda
Reviewed-on: https://go-review.googlesource.com/c/build/+/460575
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
@dmitshur dmitshur changed the title all: update js/wasm port for Node.js 1.18 all: update js/wasm port for Node.js 18 Jan 4, 2023
This was referenced Jan 4, 2023
Closed
Closed
@gopherbot
Copy link

Change https://go.dev/cl/460655 mentions this issue: cmd/internal/osinfo: report Node.js version

gopherbot pushed a commit that referenced this issue Jan 19, 2023
@dmitshur @gopherbot
cmd/internal/osinfo: report Node.js version
440ef8c 
Seeing the Node.js version that was used during a particular test run
should be helpful during the upcoming migration from Node.js 14 to 18.
Add minimal support for that.

For #57614.

Change-Id: Id55ba25a7ee4a803788316d4a646cd4b6f4297e9
Reviewed-on: https://go-review.googlesource.com/c/go/+/460655
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Richard Musiol <neelance@gmail.com>
Reviewed-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
@dmitshur dmitshur mentioned this issue Jan 24, 2023
Closed
@gopherbot
Copy link

Change https://go.dev/cl/463915 mentions this issue: dashboard: disable js-wasm TryBot (with Node 14) on Go 1.21 tree

@johanbrandhorst
Copy link
Member

I've created https://go.dev/cl/463234, https://go.dev/cl/463975 and https://go.dev/cl/463976 to deal with #57516, #56860 and #57613 respectively. I think once all 3 are merged, we should be able to build successfully for Node 18.

@gopherbot
Copy link

Change https://go.dev/cl/464036 mentions this issue: dashboard: re-enable js/wasm TryBot (with Node 18)

gopherbot pushed a commit to golang/build that referenced this issue Jan 30, 2023
@dmitshur @gopherbot
dashboard: disable js/wasm TryBot (with Node 14) on Go 1.21 tree
8267f43 
The js/wasm port maintainers want to start landing changes for
Go 1.21 that replace Node.js 14 support with Node.js 18 support.
Disable the js-wasm TryBot on tip so that work can begin.

Once done, the js-wasm-node18 builder can become the new TryBot
on tip, and the temporary misc-compile trybot can be removed.

For golang/go#57614.

Change-Id: I18ebbc69c8da2b7296dd06a5a10c8557395d600d
Reviewed-on: https://go-review.googlesource.com/c/build/+/463915
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@johanbrandhorst
Copy link
Member

New issue found by trybots: #58145

@johanbrandhorst
Copy link
Member

I expect the next issue we'll be hitting is #56498.

@johanbrandhorst johanbrandhorst mentioned this issue Feb 1, 2023
Closed
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Feb 1, 2023
@gopherbot
Copy link

Change https://go.dev/cl/463994 mentions this issue: misc: increase node stack size

gopherbot pushed a commit to golang/build that referenced this issue Feb 2, 2023
@dmitshur @gopherbot
dashboard: re-enable js/wasm TryBot (with Node 18)
a979ae3 
After all.bash is passing with Node.js 18, the js/wasm builder can be
enabled as a regular TryBot again (this time with Node 18 in place of
Node 14).

For golang/go#57614.

Change-Id: I714380fba89e37275aed4144a1e8b50e0cc57884
Reviewed-on: https://go-review.googlesource.com/c/build/+/464036
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
johanbrandhorst added a commit to Pryz/go that referenced this issue Feb 12, 2023
@johanbrandhorst
misc: increase node stack size
1ce23a1 
The default NodeJS V8 stack size is 984K, which is not enough to run
the regexp or go/parser tests. This commit increases the stack size
to 8192K, which removes the stack size limit error.

Fixes golang#56498
Fixes golang#57614

Change-Id: I357885d420daf259187403deab25ff587defa0fc
Reviewed-on: https://go-review.googlesource.com/c/go/+/463994
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Julien Fabre <ju.pryz@gmail.com>
Auto-Submit: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly issues early-in-cycle A change that should be done early in the 3 month dev cycle. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-JS umbrella
Projects
Go Release
Archived in project
Milestone
Go1.21
Development

No branches or pull requests
3 participants
@dmitshur @johanbrandhorst @gopherbot