This repository was archived by the owner on Jun 27, 2023. It is now read-only.
fix not resolving go module major versions #385
Merged
+94
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change now makes use of go list to check for package names. This tool is module aware and allows for better named imports. To test this change I needed to also add a small package to our mod file. To keep this import from disappearing from go.mod I made use of the tools file strategy. Note this change will change the import names in generated code. This should not be a breaking change in user code. Fixes #326
cvgw
approved these changes
Jan 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change now makes use of go list to check for package names. This
tool is module aware and allows for better named imports.
To test this change I needed to also add a small package to our mod
file. To keep this import from disappearing from go.mod I made use
of the tools file strategy.
Note this change will change the import names in generated code. This
should not be a breaking change in user code.
Fixes #326