{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":27522271,"defaultBranch":"master","name":"net","ownerLogin":"golang","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-12-04T04:03:57.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/4314092?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1712258828.0","currentOid":""},"activityList":{"items":[{"before":"0a24555f5cc06e8caf23d84a4f8b7102dcab838e","after":"f95a3b3a48597cebf9849b84a02cd240fb185b16","ref":"refs/heads/master","pushedAt":"2024-04-18T22:01:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"html: fix typo in package doc\n\nChange-Id: I3cacfadc0396c8ef85addd062d991bb6f5b0483a\nReviewed-on: https://go-review.googlesource.com/c/net/+/580035\nAuto-Submit: Ian Lance Taylor \nReviewed-by: Ian Lance Taylor \nCommit-Queue: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Damien Neil \nReviewed-by: Damien Neil ","shortMessageHtmlLink":"html: fix typo in package doc"}},{"before":"ec05fdcd71141c885f3fb84c41d1c692f094ccbe","after":"0a24555f5cc06e8caf23d84a4f8b7102dcab838e","ref":"refs/heads/master","pushedAt":"2024-04-15T20:44:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"http/httpguts: speed up ValidHeaderFieldName\n\nEliminate bounds checks and eschews UTF-8 decoding in ValidHeaderFieldName,\nthereby doubling its speed without introducing any allocations.\nAlso eliminate bounds checks in IsTokenRune.\n\nAdd tests and benchmarks for both ValidHeaderFieldName and IsTokenRune.\n\ngoos: darwin\ngoarch: amd64\npkg: golang.org/x/net/http/httpguts\ncpu: Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz\n │ before │ after │\n │ sec/op │ sec/op vs base │\nIsTokenRune-8 315.2n ± 0% 316.2n ± 1% ~ (p=0.245 n=20)\nValidHeaderFieldName-8 62.77n ± 0% 29.16n ± 0% -53.55% (p=0.000 n=20)\ngeomean 140.7n 96.02n -31.73%\n\n │ before │ after │\n │ B/op │ B/op vs base │\nIsTokenRune-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=20)\nValidHeaderFieldName-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=20)\ngeomean ² +0.00%\n\n │ before │ after │\n │ allocs/op │ allocs/op vs base │\nIsTokenRune-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=20)\nValidHeaderFieldName-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=20)\ngeomean ² +0.00%\n\nFixes golang/go#66700\n\nChange-Id: Ia3ea80e5f0d173e3a69eb7429023587fd7bc5933\nGitHub-Last-Rev: 1f1d25d1ecc34dca5d573c89d673dc634520df33\nGitHub-Pull-Request: golang/net#207\nReviewed-on: https://go-review.googlesource.com/c/net/+/578075\nRun-TryBot: Emmanuel Odeke \nReviewed-by: Damien Neil \nReviewed-by: Dmitri Shuralyov \nTryBot-Result: Gopher Robot \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"http/httpguts: speed up ValidHeaderFieldName"}},{"before":"cb99578fb17591790ff123c9e3acb6b68a0ce688","after":"db050b07227e0553db95938b1f9e1ea43e274127","ref":"refs/heads/internal-branch.go1.22-vendor","pushedAt":"2024-04-12T19:37:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[internal-branch.go1.22-vendor] http2: send correct LastStreamID in stream-caused GOAWAY\n\nWhen closing a connection because a stream contained a request we\ndidn't like (for example, because the request headers exceed\nthe maximum we will accept), set the LastStreamID in the GOAWAY\nframe to include the offending stream. This informs the client\nthat retrying the request is unlikely to succeed, and avoids\nretry loops.\n\nThis change requires passing the stream ID of the offending\nstream from Framer.ReadFrame up to the caller. The most sensible\nway to do this would probably be in the error. However,\nReadFrame currently returns a defined error type for\nconnection-ending errors (ConnectionError), and that type is a\nuint32 with no place to put the stream ID. Rather than changing\nthe returned errors, ReadFrame now returns an error along with\na non-nil Frame containing the stream ID, when a stream is\nresponsible for a connection-ending error.\n\nMerge conflicts were avoided by cherry-picking CL 576235 (test deflake)\nprior to this, and then by squashing CL 576175 (typo fix) into this CL.\n\nFor golang/go#66668.\nFor golang/go#66698.\n\nChange-Id: Iba07ccbd70ab4939aa56903605474d01703ac6e4\nReviewed-on: https://go-review.googlesource.com/c/net/+/576756\nReviewed-by: Jonathan Amsterdam \nReviewed-by: Dmitri Shuralyov \nAuto-Submit: Damien Neil \nLUCI-TryBot-Result: Go LUCI \nReviewed-on: https://go-review.googlesource.com/c/net/+/578338\nReviewed-by: Than McIntosh \nAuto-Submit: Dmitri Shuralyov \nReviewed-by: Dmitri Shuralyov ","shortMessageHtmlLink":"[internal-branch.go1.22-vendor] http2: send correct LastStreamID in s…"}},{"before":"76ee45185083eebe36f08838265c38e8ad20f2cd","after":"cb99578fb17591790ff123c9e3acb6b68a0ce688","ref":"refs/heads/internal-branch.go1.22-vendor","pushedAt":"2024-04-12T19:37:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[internal-branch.go1.22-vendor] http2: fix TestServerContinuationFlood flakes\n\nThis test causes the server to send a GOAWAY and close a connection.\nThe server GOAWAY path writes a GOAWAY frame asynchronously, and\ncloses the connection if the write doesn't complete within 1s.\nThis is causing failures on some builders, when the frame write\ndoesn't complete in time.\n\nThe important aspect of this test is that the connection be closed.\nDrop the check for the GOAWAY frame.\n\nThis is a test-only fix that has no effect on the vendored content,\nhelps tests on this branch, and avoids a merge conflict in next CL.\n\nFor golang/go#66698.\n\nChange-Id: I099413be9c4dfe71d8fe83d2c6242e82e282293e\nReviewed-on: https://go-review.googlesource.com/c/net/+/576235\nReviewed-by: Dmitri Shuralyov \nReviewed-by: Dmitri Shuralyov \nReviewed-by: Than McIntosh \nLUCI-TryBot-Result: Go LUCI \nReviewed-on: https://go-review.googlesource.com/c/net/+/578337\nAuto-Submit: Dmitri Shuralyov ","shortMessageHtmlLink":"[internal-branch.go1.22-vendor] http2: fix TestServerContinuationFloo…"}},{"before":"947e999f3fbf7ac4f5fb327f317c68da15030c1d","after":"ef58d90fdfc55178c3c17d2b0fded0753a2fa665","ref":"refs/heads/internal-branch.go1.21-vendor","pushedAt":"2024-04-12T19:37:48.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[internal-branch.go1.21-vendor] http2: send correct LastStreamID in stream-caused GOAWAY\n\nWhen closing a connection because a stream contained a request we\ndidn't like (for example, because the request headers exceed\nthe maximum we will accept), set the LastStreamID in the GOAWAY\nframe to include the offending stream. This informs the client\nthat retrying the request is unlikely to succeed, and avoids\nretry loops.\n\nThis change requires passing the stream ID of the offending\nstream from Framer.ReadFrame up to the caller. The most sensible\nway to do this would probably be in the error. However,\nReadFrame currently returns a defined error type for\nconnection-ending errors (ConnectionError), and that type is a\nuint32 with no place to put the stream ID. Rather than changing\nthe returned errors, ReadFrame now returns an error along with\na non-nil Frame containing the stream ID, when a stream is\nresponsible for a connection-ending error.\n\nMerge conflicts were avoided by cherry-picking CL 576235 (test deflake)\nprior to this, and then by squashing CL 576175 (typo fix) into this CL.\n\nFor golang/go#66668.\nFor golang/go#66697.\n\nChange-Id: Iba07ccbd70ab4939aa56903605474d01703ac6e4\nReviewed-on: https://go-review.googlesource.com/c/net/+/576756\nReviewed-by: Jonathan Amsterdam \nReviewed-by: Dmitri Shuralyov \nAuto-Submit: Damien Neil \nLUCI-TryBot-Result: Go LUCI \nReviewed-on: https://go-review.googlesource.com/c/net/+/578336\nReviewed-by: Damien Neil \nReviewed-by: Dmitri Shuralyov \nAuto-Submit: Dmitri Shuralyov ","shortMessageHtmlLink":"[internal-branch.go1.21-vendor] http2: send correct LastStreamID in s…"}},{"before":"b67a0f0535536b3787161ec42c08549b686a5629","after":"ec05fdcd71141c885f3fb84c41d1c692f094ccbe","ref":"refs/heads/master","pushedAt":"2024-04-05T22:13:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"http2: don't retry the first request on a connection on GOAWAY error\n\nWhen a server sends a GOAWAY frame, it indicates the ID of the\nlast stream it processed. We use this to mark any requests after\nthat stream as being safe to retry on a new connection.\n\nChange this to not retry the first request on a connection if we\nget a GOAWAY with an error, even if the GOAWAY has a stream ID\nof 0 indicating that it didn't process that request.\nIf we're getting an error as the first result on a new connection,\nthen there's either something wrong with the server or something\nwrong with our request; either way, retrying isn't likely to be\nproductive and may be unsafe.\n\nThis matches the behavior of the HTTP/1 client, which\nalso avoids retrying the first request on a new connection.\n\nFor golang/go#66668\nFixes golang/go#60636\n\nChange-Id: I90ea7cfce2974dd413f7cd8b78541678850376a5\nReviewed-on: https://go-review.googlesource.com/c/net/+/576895\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Jonathan Amsterdam ","shortMessageHtmlLink":"http2: don't retry the first request on a connection on GOAWAY error"}},{"before":"a130fcc1c15aa11de840aa4fdcae06efabc30ba4","after":"b67a0f0535536b3787161ec42c08549b686a5629","ref":"refs/heads/master","pushedAt":"2024-04-05T15:01:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"http2: send correct LastStreamID in stream-caused GOAWAY\n\nWhen closing a connection because a stream contained a request we\ndidn't like (for example, because the request headers exceed\nthe maximum we will accept), set the LastStreamID in the GOAWAY\nframe to include the offending stream. This informs the client\nthat retrying the request is unlikely to succeed, and avoids\nretry loops.\n\nThis change requires passing the stream ID of the offending\nstream from Framer.ReadFrame up to the caller. The most sensible\nway to do this would probably be in the error. However,\nReadFrame currently returns a defined error type for\nconnection-ending errors (ConnectionError), and that type is a\nuint32 with no place to put the stream ID. Rather than changing\nthe returned errors, ReadFrame now returns an error along with\na non-nil Frame containing the stream ID, when a stream is\nresponsible for a connection-ending error.\n\nFor golang/go#66668\n\nChange-Id: Iba07ccbd70ab4939aa56903605474d01703ac6e4\nReviewed-on: https://go-review.googlesource.com/c/net/+/576756\nReviewed-by: Jonathan Amsterdam \nReviewed-by: Dmitri Shuralyov \nAuto-Submit: Damien Neil \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"http2: send correct LastStreamID in stream-caused GOAWAY"}},{"before":"7bbe32058aba7159e4d273710e6f4f1c16c627fb","after":"a130fcc1c15aa11de840aa4fdcae06efabc30ba4","ref":"refs/heads/master","pushedAt":"2024-04-04T20:10:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"quic: don't consider goroutines running when tests start as leaked\n\nChange-Id: I138e284ee74c9402402f564d25e50ab753c51e9e\nReviewed-on: https://go-review.googlesource.com/c/net/+/576536\nReviewed-by: Chressie Himpel \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"quic: don't consider goroutines running when tests start as leaked"}},{"before":"c48da131589f122489348be5dfbcb6457640046f","after":"7bbe32058aba7159e4d273710e6f4f1c16c627fb","ref":"refs/heads/master","pushedAt":"2024-04-04T19:17:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I288208575b5d913be9a8b4ec87df5ca9753de151\nReviewed-on: https://go-review.googlesource.com/c/net/+/576516\nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Gopher Robot \nReviewed-by: Dmitri Shuralyov \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"go.mod: update golang.org/x dependencies"}},{"before":"762b58d1cf6e0779780decad89c6c1523386638d","after":"c48da131589f122489348be5dfbcb6457640046f","ref":"refs/heads/master","pushedAt":"2024-04-03T17:30:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"http2: fix TestServerContinuationFlood flakes\n\nThis test causes the server to send a GOAWAY and close a connection.\nThe server GOAWAY path writes a GOAWAY frame asynchronously, and\ncloses the connection if the write doesn't complete within 1s.\nThis is causing failures on some builders, when the frame write\ndoesn't complete in time.\n\nThe important aspect of this test is that the connection be closed.\nDrop the check for the GOAWAY frame.\n\nChange-Id: I099413be9c4dfe71d8fe83d2c6242e82e282293e\nReviewed-on: https://go-review.googlesource.com/c/net/+/576235\nReviewed-by: Dmitri Shuralyov \nReviewed-by: Dmitri Shuralyov \nReviewed-by: Than McIntosh \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"http2: fix TestServerContinuationFlood flakes"}},{"before":"ae3c50b55fdf451bc6ee4e65a72a2f67606440d8","after":"76ee45185083eebe36f08838265c38e8ad20f2cd","ref":"refs/heads/internal-branch.go1.22-vendor","pushedAt":"2024-04-03T17:07:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[internal-branch.go1.22-vendor] http2: close connections when receiving too many headers\n\nMaintaining HPACK state requires that we parse and process\nall HEADERS and CONTINUATION frames on a connection.\nWhen a request's headers exceed MaxHeaderBytes, we don't\nallocate memory to store the excess headers but we do\nparse them. This permits an attacker to cause an HTTP/2\nendpoint to read arbitrary amounts of data, all associated\nwith a request which is going to be rejected.\n\nSet a limit on the amount of excess header frames we\nwill process before closing a connection.\n\nThanks to Bartek Nowotarski for reporting this issue.\n\nFixes CVE-2023-45288\nFor golang/go#65051\n\nChange-Id: I15df097268df13bb5a9e9d3a5c04a8a141d850f6\nReviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/2130527\nReviewed-by: Roland Shoemaker \nReviewed-by: Tatiana Bradley \nReviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/2197263\nReviewed-by: Dmitri Shuralyov \nRun-TryBot: Damien Neil \nReviewed-on: https://go-review.googlesource.com/c/net/+/576215\nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Dmitri Shuralyov ","shortMessageHtmlLink":"[internal-branch.go1.22-vendor] http2: close connections when receivi…"}},{"before":"1a2eef3ba5365497a74c3f61c59262f4a6f02685","after":"947e999f3fbf7ac4f5fb327f317c68da15030c1d","ref":"refs/heads/internal-branch.go1.21-vendor","pushedAt":"2024-04-03T17:06:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[internal-branch.go1.21-vendor] http2: close connections when receiving too many headers\n\nMaintaining HPACK state requires that we parse and process\nall HEADERS and CONTINUATION frames on a connection.\nWhen a request's headers exceed MaxHeaderBytes, we don't\nallocate memory to store the excess headers but we do\nparse them. This permits an attacker to cause an HTTP/2\nendpoint to read arbitrary amounts of data, all associated\nwith a request which is going to be rejected.\n\nSet a limit on the amount of excess header frames we\nwill process before closing a connection.\n\nThanks to Bartek Nowotarski for reporting this issue.\n\nFixes CVE-2023-45288\nFor golang/go#65051\n\nChange-Id: I15df097268df13bb5a9e9d3a5c04a8a141d850f6\nReviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/2130527\nReviewed-by: Roland Shoemaker \nReviewed-by: Tatiana Bradley \nReviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/2197243\nRun-TryBot: Damien Neil \nReviewed-by: Dmitri Shuralyov \nReviewed-on: https://go-review.googlesource.com/c/net/+/576057\nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Dmitri Shuralyov ","shortMessageHtmlLink":"[internal-branch.go1.21-vendor] http2: close connections when receivi…"}},{"before":"ba872109ef2dc8f1da778651bd1fd3792d0e4587","after":"762b58d1cf6e0779780decad89c6c1523386638d","ref":"refs/heads/master","pushedAt":"2024-04-03T16:51:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"http2: fix tipos in comment\n\nChange-Id: I20cd0f8db534fe2a849306eb7e0c8ee5b434e88f\nReviewed-on: https://go-review.googlesource.com/c/net/+/576175\nAuto-Submit: Ian Lance Taylor \nReviewed-by: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Damien Neil ","shortMessageHtmlLink":"http2: fix tipos in comment"}},{"before":"ebc8168ac8ac742194df729305175940790c55a2","after":"ba872109ef2dc8f1da778651bd1fd3792d0e4587","ref":"refs/heads/master","pushedAt":"2024-04-03T16:01:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"http2: close connections when receiving too many headers\n\nMaintaining HPACK state requires that we parse and process\nall HEADERS and CONTINUATION frames on a connection.\nWhen a request's headers exceed MaxHeaderBytes, we don't\nallocate memory to store the excess headers but we do\nparse them. This permits an attacker to cause an HTTP/2\nendpoint to read arbitrary amounts of data, all associated\nwith a request which is going to be rejected.\n\nSet a limit on the amount of excess header frames we\nwill process before closing a connection.\n\nThanks to Bartek Nowotarski for reporting this issue.\n\nFixes CVE-2023-45288\nFixes golang/go#65051\n\nChange-Id: I15df097268df13bb5a9e9d3a5c04a8a141d850f6\nReviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/2130527\nReviewed-by: Roland Shoemaker \nReviewed-by: Tatiana Bradley \nReviewed-on: https://go-review.googlesource.com/c/net/+/576155\nReviewed-by: Dmitri Shuralyov \nAuto-Submit: Dmitri Shuralyov \nReviewed-by: Than McIntosh \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"http2: close connections when receiving too many headers"}},{"before":"5ca955b1789c4482c855601099c480100451b259","after":"1a2eef3ba5365497a74c3f61c59262f4a6f02685","ref":"refs/heads/internal-branch.go1.21-vendor","pushedAt":"2024-03-27T21:44:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[internal-branch.go1.21-vendor] http2: reject DATA frames after 1xx and before final headers\n\nWhen checking to see if a DATA frame can be accepted, check to\nsee if we have received a non-1xx header, not whether we have\nreceived any header.\n\nFor golang/go#65927\nFixes golang/go#66254\n\nChange-Id: Id4fae1862de6179f8fc95e02dec7d4c47a7640e1\nReviewed-on: https://go-review.googlesource.com/c/net/+/567175\nReviewed-by: Jonathan Amsterdam \nLUCI-TryBot-Result: Go LUCI \nReviewed-on: https://go-review.googlesource.com/c/net/+/574855\nAuto-Submit: Dmitri Shuralyov \nReviewed-by: Dmitri Shuralyov \nReviewed-by: Dmitri Shuralyov ","shortMessageHtmlLink":"[internal-branch.go1.21-vendor] http2: reject DATA frames after 1xx a…"}},{"before":"a8e0109124268a0a063b5900bce0c2b33398ec01","after":"ae3c50b55fdf451bc6ee4e65a72a2f67606440d8","ref":"refs/heads/internal-branch.go1.22-vendor","pushedAt":"2024-03-27T21:43:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[internal-branch.go1.22-vendor] http2: reject DATA frames after 1xx and before final headers\n\nWhen checking to see if a DATA frame can be accepted, check to\nsee if we have received a non-1xx header, not whether we have\nreceived any header.\n\nFor golang/go#65927\nFixes golang/go#66255\n\nChange-Id: Id4fae1862de6179f8fc95e02dec7d4c47a7640e1\nReviewed-on: https://go-review.googlesource.com/c/net/+/567175\nReviewed-by: Jonathan Amsterdam \nLUCI-TryBot-Result: Go LUCI \nReviewed-on: https://go-review.googlesource.com/c/net/+/574875\nReviewed-by: Dmitri Shuralyov \nReviewed-by: Dmitri Shuralyov \nAuto-Submit: Dmitri Shuralyov ","shortMessageHtmlLink":"[internal-branch.go1.22-vendor] http2: reject DATA frames after 1xx a…"}},{"before":"ebc8168ac8ac742194df729305175940790c55a2","after":"a8e0109124268a0a063b5900bce0c2b33398ec01","ref":"refs/heads/internal-branch.go1.22-vendor","pushedAt":"2024-03-27T16:58:13.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: Ia3b446633ffc0b3264692cfaae765bfb79063dab\nReviewed-on: https://go-review.googlesource.com/c/net/+/545175\nAuto-Submit: Gopher Robot \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Knyszek \nReviewed-by: Dmitri Shuralyov ","shortMessageHtmlLink":"go.mod: update golang.org/x dependencies"}},{"before":null,"after":"ebc8168ac8ac742194df729305175940790c55a2","ref":"refs/heads/internal-branch.go1.22-vendor","pushedAt":"2024-03-27T15:27:19.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"all: fix some typos\n\nChange-Id: I7e2c867efcc960553da77e395b0069ab6776cd9f\nGitHub-Last-Rev: eaa122d1b6086c22f329227053411b0a73a5215b\nGitHub-Pull-Request: golang/net#205\nReviewed-on: https://go-review.googlesource.com/c/net/+/572995\nReviewed-by: Emmanuel Odeke \nReviewed-by: David Chase \nAuto-Submit: Damien Neil \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Damien Neil ","shortMessageHtmlLink":"all: fix some typos"}},{"before":"3678185f8a652e52864c44049a9ea96b7bcc066a","after":"ebc8168ac8ac742194df729305175940790c55a2","ref":"refs/heads/master","pushedAt":"2024-03-21T09:28:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"all: fix some typos\n\nChange-Id: I7e2c867efcc960553da77e395b0069ab6776cd9f\nGitHub-Last-Rev: eaa122d1b6086c22f329227053411b0a73a5215b\nGitHub-Pull-Request: golang/net#205\nReviewed-on: https://go-review.googlesource.com/c/net/+/572995\nReviewed-by: Emmanuel Odeke \nReviewed-by: David Chase \nAuto-Submit: Damien Neil \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Damien Neil ","shortMessageHtmlLink":"all: fix some typos"}},{"before":"448c44f9287b6745f958d74aa2a17ec7761c2f13","after":"3678185f8a652e52864c44049a9ea96b7bcc066a","ref":"refs/heads/master","pushedAt":"2024-03-20T19:56:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"http2: make TestCanonicalHeaderCacheGrowth faster\n\nLower the number of iterations that this test runs for.\nReduces runtime with -race from 27s on my M1 Mac to 0.06s.\n\nChange-Id: Ibd4b225277c79d9030c0a21b3077173a787cc4c1\nReviewed-on: https://go-review.googlesource.com/c/net/+/572656\nReviewed-by: Jonathan Amsterdam \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"http2: make TestCanonicalHeaderCacheGrowth faster"}},{"before":"c7877ac4213b2f859831366f5a35b353e0dc9f66","after":"448c44f9287b6745f958d74aa2a17ec7761c2f13","ref":"refs/heads/master","pushedAt":"2024-03-20T19:56:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"http2: remove clientTester\n\nAll tests which use clientTester have been converted to use\ntestClientConn, so delete clientTester.\n\nChange-Id: Id9a88bf7ee6760fada8442d383d5e68455c6dc3e\nReviewed-on: https://go-review.googlesource.com/c/net/+/572815\nReviewed-by: Jonathan Amsterdam \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"http2: remove clientTester"}},{"before":"d73acffdc9493532acb85777105bb4a351eea702","after":"c7877ac4213b2f859831366f5a35b353e0dc9f66","ref":"refs/heads/master","pushedAt":"2024-03-20T17:26:43.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"http2: convert the remaining clientTester tests to testClientConn\n\nChange-Id: Ia7f213346baff48504fef6dfdc112575a5459f35\nReviewed-on: https://go-review.googlesource.com/c/net/+/572380\nReviewed-by: Jonathan Amsterdam \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"http2: convert the remaining clientTester tests to testClientConn"}},{"before":"89f602b7bbf237abe0467031a18b42fc742ced08","after":"d73acffdc9493532acb85777105bb4a351eea702","ref":"refs/heads/master","pushedAt":"2024-03-20T11:27:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"http2: only set up deadline when Server.IdleTimeout is positive\n\nCheck out https://go-review.googlesource.com/c/go/+/570396\n\nChange-Id: I8bda17acebc27308c2a1723191ea1e4a9e64d585\nReviewed-on: https://go-review.googlesource.com/c/net/+/570455\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: David Chase \nReviewed-by: Damien Neil \nAuto-Submit: Damien Neil ","shortMessageHtmlLink":"http2: only set up deadline when Server.IdleTimeout is positive"}},{"before":"6e2c99c943496e33025da68db088edff5dc7d07b","after":"89f602b7bbf237abe0467031a18b42fc742ced08","ref":"refs/heads/master","pushedAt":"2024-03-19T21:21:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"http2: validate client/outgoing trailers\n\nThis change is a counterpart to the HTTP/1.1 trailers\nvalidation CL 572615. This change will ensure that we\nvalidate trailers that were set on the HTTP client\nbefore they are transformed to HTTP/2 equivalents.\n\nUpdates golang/go#64766\n\nChange-Id: Id1afd7f7e9af820ea969ef226bbb16e4de6d57a5\nReviewed-on: https://go-review.googlesource.com/c/net/+/572655\nAuto-Submit: Damien Neil \nTryBot-Result: Gopher Robot \nReviewed-by: Damien Neil \nRun-TryBot: Emmanuel Odeke \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: David Chase ","shortMessageHtmlLink":"http2: validate client/outgoing trailers"}},{"before":"9e0498de4d22259990fc8eb8440eafd7c353c19c","after":"6e2c99c943496e33025da68db088edff5dc7d07b","ref":"refs/heads/master","pushedAt":"2024-03-19T17:01:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"http2: allow testing Transports with testSyncHooks\n\nChange-Id: Icafc4860ef0691e5133221a0b53bb1d2158346cc\nReviewed-on: https://go-review.googlesource.com/c/net/+/572378\nReviewed-by: Jonathan Amsterdam \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"http2: allow testing Transports with testSyncHooks"}},{"before":"31d9683ed011ab20a0aa6ab62de563611851a2b8","after":"9e0498de4d22259990fc8eb8440eafd7c353c19c","ref":"refs/heads/master","pushedAt":"2024-03-19T17:01:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"http2: use synthetic timers for ping timeouts in tests\n\nChange-Id: I642890519b066937ade3c13e8387c31d29e912f4\nReviewed-on: https://go-review.googlesource.com/c/net/+/572377\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Jonathan Amsterdam ","shortMessageHtmlLink":"http2: use synthetic timers for ping timeouts in tests"}},{"before":"12ddef72728707026a3d9adbbc28affa76faf688","after":"31d9683ed011ab20a0aa6ab62de563611851a2b8","ref":"refs/heads/master","pushedAt":"2024-03-19T00:21:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"http2: mark several testing functions as helpers\n\nChange-Id: Ib5519fd882b3692efadd6191fbebbf042c9aa77d\nReviewed-on: https://go-review.googlesource.com/c/net/+/572376\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Jonathan Amsterdam ","shortMessageHtmlLink":"http2: mark several testing functions as helpers"}},{"before":"d600ae05799943851536e26ab37ee23294912c3d","after":"12ddef72728707026a3d9adbbc28affa76faf688","ref":"refs/heads/master","pushedAt":"2024-03-11T21:02:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"http2: reject DATA frames after 1xx and before final headers\n\nWhen checking to see if a DATA frame can be accepted, check to\nsee if we have received a non-1xx header, not whether we have\nreceived any header.\n\nFixes golang/go#65927\n\nChange-Id: Id4fae1862de6179f8fc95e02dec7d4c47a7640e1\nReviewed-on: https://go-review.googlesource.com/c/net/+/567175\nReviewed-by: Jonathan Amsterdam \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"http2: reject DATA frames after 1xx and before final headers"}},{"before":"57a6a7a86bc0e47508781ed988adcecbe8ff2580","after":"d600ae05799943851536e26ab37ee23294912c3d","ref":"refs/heads/master","pushedAt":"2024-03-11T21:02:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"http2: add testClientConn for testing client RoundTrips\n\nMany RoundTrip tests involve testing against a test-defined\nserver with specific behaviors. For example: Testing\nRoundTrip's behavior when the server violates flow\ncontrol limits.\n\nExisting tests mostly use the clientTester type, which\nstarts separate goroutines for the Transport and a fake\nserver. This results in tests where the control flow\nbounces around the test function, and requires each\ntest to manage its own synchronization.\n\nIntroduce a new framework for writing RoundTrip tests.\ntestClientConn allows client tests to be written linearly,\nwith synchronization provided by the test framework.\nFor example, a testClientConn test can, as a linear\nsequence of actions:\n\n - start RoundTrip;\n - check the request headers sent;\n - provide data to the request body;\n - check that a DATA frame is sent;\n - send response headers from the server to the client;\n - check that RoundTrip returns.\n\nSee TestTestClientConn at the top of clientconn_test.go\nfor a full example.\n\nTo enable synchronization with tests, this CL\ninstruments the RoundTrip path to record when\ngoroutines start, exit, and block waiting for events.\nThis adds a certain amount of noise and bookkeeping\nto the client implementation, but (in my opinion)\nthis is more than repaid in improved testability.\n\nThe testClientConn also permits use of synthetic\ntime in tests. At the moment, this is limited to\nthe response header timeout, but extending it to\nother timeouts (read, 100-continue) should be\nstraightforward.\n\nThis CL converts a number of existing clientTester tests\nto use the new framework, but not all.\n\nChange-Id: Ief963889969363ec8469cd3c3de0becb2fc548f9\nReviewed-on: https://go-review.googlesource.com/c/net/+/563540\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Jonathan Amsterdam ","shortMessageHtmlLink":"http2: add testClientConn for testing client RoundTrips"}},{"before":"ea095bc79b94b4bdc6939ce2dbd0300520089a1f","after":"57a6a7a86bc0e47508781ed988adcecbe8ff2580","ref":"refs/heads/master","pushedAt":"2024-03-08T17:42:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"http2: prevent uninitialized pipe from being written\n\nFor golang/go#65927\n\nChange-Id: I6f48706156384e026968cf9a6d9e0ec76b46fabf\nReviewed-on: https://go-review.googlesource.com/c/net/+/566675\nReviewed-by: Damien Neil \nReviewed-by: Carlos Amedee \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"http2: prevent uninitialized pipe from being written"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAENJolBAA","startCursor":null,"endCursor":null}},"title":"Activity · golang/net"}