Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jwt: errors from http client is not wrapped in error #635

Open
jkralik opened this issue Mar 13, 2023 · 1 comment · May be fixed by #636
Open

jwt: errors from http client is not wrapped in error #635

jkralik opened this issue Mar 13, 2023 · 1 comment · May be fixed by #636

Comments

@jkralik
Copy link

jkralik commented Mar 13, 2023 •
edited

Pls replace %v by %w in fmt.Errorf for wrapping errors.
eg:

oauth2/internal/token.go

Line 237 in 2fc4ef5

return nil, fmt.Errorf("oauth2: cannot fetch token: %v", err)

oauth2/jwt/jwt.go

Line 136 in 2fc4ef5

return nil, fmt.Errorf("oauth2: cannot fetch token: %v", err)

oauth2/jwt/jwt.go

Line 141 in 2fc4ef5

return nil, fmt.Errorf("oauth2: cannot fetch token: %v", err)

oauth2/jwt/jwt.go

Line 157 in 2fc4ef5

return nil, fmt.Errorf("oauth2: cannot fetch token: %v", err)

oauth2/jwt/jwt.go

Line 174 in 2fc4ef5

return nil, fmt.Errorf("oauth2: error decoding JWT token: %v", err)

...
jkralik added a commit to plgd-dev/hub that referenced this issue Mar 13, 2023
@jkralik
coap-gateway: add more error key words for temporary errors
466482b 
jwt package doesn't propagate corretly error

golang/oauth2#635
@jkralik jkralik mentioned this issue Mar 13, 2023
Merged
jkralik added a commit to plgd-dev/hub that referenced this issue Mar 13, 2023
@jkralik
coap-gateway: check if oauth2 errors are temporary
0d4ead4 
jwt package doesn't propagate correctly error:
golang/oauth2#635
jkralik added a commit to plgd-dev/hub that referenced this issue Mar 14, 2023
@jkralik
coap-gateway: check if oauth2 errors are temporary
ef3df4c 
jwt package doesn't propagate correctly error:
golang/oauth2#635
jkralik added a commit to plgd-dev/hub that referenced this issue Mar 14, 2023
@jkralik
coap-gateway: check if oauth2 errors are temporary
e05d346 
jwt package doesn't propagate correctly error:
golang/oauth2#635
@1garo 1garo linked a pull request Mar 14, 2023 that will close this issue
Open
@1garo
Copy link

1garo commented Mar 14, 2023 •
edited

opened a PR to solve this! @jkralik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

wrap http client errors with %w 1garo/oauth2
2 participants
@jkralik @1garo